| Summary: | Load Media Controls js/css from bundle | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||||||
| Component: | Media | Assignee: | Dean Jackson <dino> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, eric.carlson, esprehn+autocc, glenn, jer.noble, kondapallykalyan, rniwa, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 131194 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 228349 [details]
Patch
Comment on attachment 228349 [details] Patch Attachment 228349 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6493476329881600 New failing tests: platform/mac/fast/scrolling/scroll-iframe-latched-mainframe.html media/adopt-node-crash.html platform/mac/fast/scrolling/scroll-select-latched-mainframe.html platform/mac/fast/scrolling/scroll-div-latched-mainframe.html Created attachment 228356 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Thanks. I'll upload one more patch to check EWS. The failure report wasn't very helpful - just said that something before that media test failed. When I run it locally on WK2 everything passes. Created attachment 228427 [details]
Patch
Committed r166669: <http://trac.webkit.org/changeset/166669> |
On Mac/iOS we should load the mediaControls*.{js,css} files from the bundle rather than inserting encoded versions into the C source code.