Bug 131086

Summary:

Load Media Controls js/css from bundle

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

Media

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, eric.carlson, esprehn+autocc, glenn, jer.noble, kondapallykalyan, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

131194

Attachments:

Description	Flags
Patch	eric.carlson: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2	none
Patch	sam: review+

Dean Jackson

Reported 2014-04-01 17:43:25 PDT

On Mac/iOS we should load the mediaControls*.{js,css} files from the bundle rather than inserting encoded versions into the C source code.

Attachments
Patch (13.50 KB, patch) 2014-04-01 17:46 PDT, Dean Jackson	eric.carlson: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (581.09 KB, application/zip) 2014-04-01 18:39 PDT, Build Bot	no flags	Details
Patch (13.53 KB, patch) 2014-04-02 14:03 PDT, Dean Jackson	sam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-04-01 17:44:45 PDT

<rdar://problem/16494419>

Dean Jackson

Comment 2 2014-04-01 17:46:11 PDT

Created attachment 228349 [details] Patch

Build Bot

Comment 3 2014-04-01 18:39:26 PDT

Comment on attachment 228349 [details] Patch Attachment 228349 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6493476329881600 New failing tests: platform/mac/fast/scrolling/scroll-iframe-latched-mainframe.html media/adopt-node-crash.html platform/mac/fast/scrolling/scroll-select-latched-mainframe.html platform/mac/fast/scrolling/scroll-div-latched-mainframe.html

Build Bot

Comment 4 2014-04-01 18:39:29 PDT

Created attachment 228356 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Dean Jackson

Comment 5 2014-04-02 11:26:02 PDT

Thanks. I'll upload one more patch to check EWS. The failure report wasn't very helpful - just said that something before that media test failed. When I run it locally on WK2 everything passes.

Dean Jackson

Comment 6 2014-04-02 14:03:09 PDT

Created attachment 228427 [details] Patch

Dean Jackson

Comment 7 2014-04-02 14:44:56 PDT

Committed r166669: <http://trac.webkit.org/changeset/166669>

Note You need to log in before you can comment on or make changes to this bug.