Bug 131055

Summary: Eliminate HTMLFormElement::m_shouldSubmit
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: FormsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch thorton: review+

Alexey Proskuryakov
Reported 2014-04-01 13:43:31 PDT
HTMLFormElement::m_shouldSubmit is confusing an unnecessary.
Attachments
proposed patch (4.11 KB, patch)
2014-04-01 13:50 PDT, Alexey Proskuryakov 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-04-01 13:50:25 PDT
Created attachment 228315 [details] proposed patch
Tim Horton
Comment 2 2014-04-01 14:15:03 PDT
Comment on attachment 228315 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=228315&action=review > Source/WebCore/ChangeLog:9 > + - as a return value in a funciton whose return value is ignored by all callers; funciton
Alexey Proskuryakov
Comment 3 2014-04-01 14:57:49 PDT
Committed <http://trac.webkit.org/r166615>.
mitz
Comment 4 2014-04-03 23:19:42 PDT
(In reply to comment #3) > Committed <http://trac.webkit.org/r166615>. See bug 131212.
Note You need to log in before you can comment on or make changes to this bug.