Bug 130562

Summary: FTL should correctly compile GetByVal on Uint32Array that claims to return non-int32 values
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, ggaren, mark.lam, mhahnenberg, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 112840    
Attachments:
Description Flags
the patch none

Filip Pizlo
Reported 2014-03-20 22:00:23 PDT
The type inference will decide that this returns MachineInt, but the FTL thinks that it returns a double.
Attachments
the patch (2.04 KB, patch)
2014-03-20 22:02 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-03-20 22:02:11 PDT
Created attachment 227383 [details] the patch
Nadav Rotem
Comment 2 2014-03-20 22:07:57 PDT
LGTM.
Geoffrey Garen
Comment 3 2014-03-20 23:18:02 PDT
Comment on attachment 227383 [details] the patch r=me
WebKit Commit Bot
Comment 4 2014-03-20 23:51:46 PDT
Comment on attachment 227383 [details] the patch Clearing flags on attachment: 227383 Committed r166045: <http://trac.webkit.org/changeset/166045>
WebKit Commit Bot
Comment 5 2014-03-20 23:51:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.