Bug 130562 - FTL should correctly compile GetByVal on Uint32Array that claims to return non-int32 values
Summary: FTL should correctly compile GetByVal on Uint32Array that claims to return no...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112840
  Show dependency treegraph
 
Reported: 2014-03-20 22:00 PDT by Filip Pizlo
Modified: 2014-03-20 23:51 PDT (History)
9 users (show)

See Also:


Attachments
the patch (2.04 KB, patch)
2014-03-20 22:02 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-03-20 22:00:23 PDT
The type inference will decide that this returns MachineInt, but the FTL thinks that it returns a double.
Comment 1 Filip Pizlo 2014-03-20 22:02:11 PDT
Created attachment 227383 [details]
the patch
Comment 2 Nadav Rotem 2014-03-20 22:07:57 PDT
LGTM.
Comment 3 Geoffrey Garen 2014-03-20 23:18:02 PDT
Comment on attachment 227383 [details]
the patch

r=me
Comment 4 WebKit Commit Bot 2014-03-20 23:51:46 PDT
Comment on attachment 227383 [details]
the patch

Clearing flags on attachment: 227383

Committed r166045: <http://trac.webkit.org/changeset/166045>
Comment 5 WebKit Commit Bot 2014-03-20 23:51:49 PDT
All reviewed patches have been landed.  Closing bug.