Bug 130115

Summary: [DFG] DCE claims to preserve CPS but does not preserve it in the strictest form, specifically variables-at-tail for captured variables
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: barraclough, commit-queue, fpizlo, geryxyz, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, ossy, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 130069    
Bug Blocks:    
Attachments:
Description Flags
proposed patch
none
style fix on patch none

Filip Pizlo
Reported 2014-03-11 21:30:23 PDT
This is a benign bug but it might become serious if we try to run DCE sooner or if we add more things in the back of the backend that rely on CPS.
Attachments
proposed patch (5.79 KB, patch)
2014-08-29 00:03 PDT, Gergő Balogh 		no flags
DetailsFormatted DiffDiff
style fix on patch (5.79 KB, patch)
2014-08-29 00:09 PDT, Gergő Balogh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gergo "avatar" Balogh
Comment 1 2014-07-28 23:06:06 PDT
Hello, I notice that you are assigned to this bug, but it is inactive since its report. I would like to work on this. Do you mind if I begin to work on this? (In reply to comment #0) > This is a benign bug but it might become serious if we try to run DCE sooner or if we add more things in the back of the backend that rely on CPS.
Gergő Balogh
Comment 2 2014-08-29 00:03:29 PDT
Created attachment 237337 [details] proposed patch
WebKit Commit Bot
Comment 3 2014-08-29 00:05:51 PDT
Attachment 237337 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGDCEPhase.cpp:343: Declaration has space between type name and * in Node *node [whitespace/declaration] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gergő Balogh
Comment 4 2014-08-29 00:09:23 PDT
Created attachment 237338 [details] style fix on patch
Filip Pizlo
Comment 5 2015-03-01 20:41:20 PST
*** This bug has been marked as a duplicate of bug 141174 ***
Note You need to log in before you can comment on or make changes to this bug.