| Summary: | [DFG] DCE claims to preserve CPS but does not preserve it in the strictest form, specifically variables-at-tail for captured variables | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||
| Status: | RESOLVED DUPLICATE | ||||||||
| Severity: | Normal | CC: | barraclough, commit-queue, fpizlo, geryxyz, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, ossy, sam | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | 130069 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Filip Pizlo
2014-03-11 21:30:23 PDT
Hello, I notice that you are assigned to this bug, but it is inactive since its report. I would like to work on this. Do you mind if I begin to work on this? (In reply to comment #0) > This is a benign bug but it might become serious if we try to run DCE sooner or if we add more things in the back of the backend that rely on CPS. Created attachment 237337 [details]
proposed patch
Attachment 237337 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/dfg/DFGDCEPhase.cpp:343: Declaration has space between type name and * in Node *node [whitespace/declaration] [3]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 237338 [details]
style fix on patch
*** This bug has been marked as a duplicate of bug 141174 *** |