Bug 130115 - [DFG] DCE claims to preserve CPS but does not preserve it in the strictest form, specifically variables-at-tail for captured variables
Summary: [DFG] DCE claims to preserve CPS but does not preserve it in the strictest fo...
Status: RESOLVED DUPLICATE of bug 141174
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 130069
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-11 21:30 PDT by Filip Pizlo
Modified: 2015-05-11 03:41 PDT (History)
13 users (show)

See Also:

Attachments
proposed patch (5.79 KB, patch)
2014-08-29 00:03 PDT, Gergő Balogh 		no flags Details | Formatted Diff | Diff
style fix on patch (5.79 KB, patch)
2014-08-29 00:09 PDT, Gergő Balogh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-03-11 21:30:23 PDT 
This is a benign bug but it might become serious if we try to run DCE sooner or if we add more things in the back of the backend that rely on CPS.
Comment 1 Gergo "avatar" Balogh 2014-07-28 23:06:06 PDT 
Hello,

I notice that you are assigned to this bug, but it is inactive since its report. I would like to work on this. Do you mind if I begin to work on this? (In reply to comment #0)

> This is a benign bug but it might become serious if we try to run DCE sooner or if we add more things in the back of the backend that rely on CPS.
Comment 2 Gergő Balogh 2014-08-29 00:03:29 PDT 
Created attachment 237337 [details]
proposed patch
Comment 3 WebKit Commit Bot 2014-08-29 00:05:51 PDT 
Attachment 237337 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGDCEPhase.cpp:343:  Declaration has space between type name and * in Node *node  [whitespace/declaration] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Gergő Balogh 2014-08-29 00:09:23 PDT 
Created attachment 237338 [details]
style fix on patch
Comment 5 Filip Pizlo 2015-03-01 20:41:20 PST 

*** This bug has been marked as a duplicate of bug 141174 ***