Bug 130041

Summary:

Repatch should save and restore all used registers - not just temp ones - when making a call

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, commit-queue, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

112840

Attachments:

Description	Flags
the patch	ggaren: review+

Description Filip Pizlo 2014-03-10 14:30:24 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2014-03-10 14:32:47 PDT

Created attachment 226335 [details]
the patch

Comment 2 WebKit Commit Bot 2014-03-10 14:34:25 PDT

Attachment 226335 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/jit/ScratchRegisterAllocator.h:72:  The parameter name "scratchBuffer" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/jit/ScratchRegisterAllocator.h:74:  The parameter name "scratchBuffer" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Geoffrey Garen 2014-03-10 14:37:43 PDT

Comment on attachment 226335 [details]
the patch

r=me

Comment 4 Filip Pizlo 2014-03-10 16:26:13 PDT

Landed in http://trac.webkit.org/changeset/165414