Bug 129838

Summary: [CSS Shapes] inset complex calc() args vanish in serialized computed style
Product: WebKit Reporter: Rebecca Hauck <rhauck>
Component: CSSAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, gyuyoung.kim, macpherson, menard, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98664    
Attachments:
Description Flags
Test case for bug
none
fixed test case file (added prefixes)
none
Patch none

Rebecca Hauck
Reported 2014-03-06 15:29:51 PST
The attached test file tests this: inset(calc(25%*3 - 10in)) getComputedStyle(div).getPropertyValue('-webkit-shape-outside') returns: inset( round 0px 0px 0px 0px / 0px 0px 0px 0px) The inset args completely vanish. Some additional info: - The inline style version of this test passes - If I drop the '- 10in' from the calc() the args don't vanish
Attachments
Test case for bug (866 bytes, text/html)
2014-03-06 15:30 PST, Rebecca Hauck 		no flags
Details
fixed test case file (added prefixes) (882 bytes, text/html)
2014-03-06 15:41 PST, Rebecca Hauck 		no flags
Details
Patch (5.19 KB, patch)
2014-04-07 16:02 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rebecca Hauck
Comment 1 2014-03-06 15:30:25 PST
Created attachment 226049 [details] Test case for bug
Rebecca Hauck
Comment 2 2014-03-06 15:30:43 PST
Note: This uses testharness.js and the relative path in the test assumes the test is run from LayoutTests/fast/shapes/parsing
Rebecca Hauck
Comment 3 2014-03-06 15:41:13 PST
Created attachment 226052 [details] fixed test case file (added prefixes)
Zoltan Horvath
Comment 4 2014-04-07 16:02:46 PDT
Created attachment 228766 [details] Patch
Zoltan Horvath
Comment 5 2014-04-07 16:14:16 PDT
Comment on attachment 228766 [details] Patch Note: the simplest serialization for shapes will be implemented in bug #129825.
Bem Jones-Bey
Comment 6 2014-04-07 16:23:41 PDT
Comment on attachment 228766 [details] Patch r=me
WebKit Commit Bot
Comment 7 2014-04-07 17:02:25 PDT
Comment on attachment 228766 [details] Patch Clearing flags on attachment: 228766 Committed r166894: <http://trac.webkit.org/changeset/166894>
WebKit Commit Bot
Comment 8 2014-04-07 17:02:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.