Bug 129825 – [CSS Shapes] inset args and radial args should serialize to the simplest form

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Rebecca Hauck]

From Section 3.3 of the spec:
http://dev.w3.org/csswg/css-shapes/#basic-shape-serialization

To serialize the <basic-shape> functions, serialize as per their individual grammars, in the order the grammars are written in, avoiding calc() expressions where possible, avoiding calc() transformations, omitting components when possible without changing the meaning, joining space-separated tokens with a single space, and following each serialized comma with a single space.

The attached tests has 2 examples of inset() serialization:

----------------------------
value:  inset(10px)  
actual: inset(10px 10px 10px 10px)
expected: inset(10px) 
-----------------------------
value: inset(10px round 20px) 
actual: inset(10px 10px 10px 10px round 20px 20px 20px 20px / 20px 20px 20px 20px)
expected: inset(10px round 20px) 
-----------------------------

Note: This uses testharness.js and the relative path in the test assumes the test is run from LayoutTests/fast/shapes/parsing

[Rebecca Hauck]

Created attachment 226037 [details]
Test case for bug

[Zoltan Horvath]

Rob is started to work on this bug in Blink: https://code.google.com/p/chromium/issues/detail?id=350092 Let's wait for him, then we can port the patch over to WebKit.

[Bear Travis]

Created attachment 229004 [details]
Patch

[Build Bot]

Comment on attachment 229004 [details]
Patch

Attachment 229004 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4906653015080960

New failing tests:
css3/masking/clip-path-animation.html

[Build Bot]

Created attachment 229013 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 229004 [details]
Patch

Attachment 229004 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5646063847342080

New failing tests:
css3/masking/clip-path-animation.html

[Build Bot]

Created attachment 229014 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 229004 [details]
Patch

Attachment 229004 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4737813689925632

New failing tests:
css3/masking/clip-path-animation.html

[Build Bot]

Created attachment 229015 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Bear Travis]

Created attachment 229074 [details]
Updated patch

[Dirk Schulze]

Comment on attachment 229074 [details]
Updated patch

r=me

[WebKit Commit Bot]

Comment on attachment 229074 [details]
Updated patch

Clearing flags on attachment: 229074

Committed r167132: <http://trac.webkit.org/changeset/167132>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.