Bug 129838 - [CSS Shapes] inset complex calc() args vanish in serialized computed style
Summary: [CSS Shapes] inset complex calc() args vanish in serialized computed style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks: 98664
  Show dependency treegraph
 
Reported: 2014-03-06 15:29 PST by Rebecca Hauck
Modified: 2014-04-07 17:02 PDT (History)
7 users (show)

See Also:


Attachments
Test case for bug (866 bytes, text/html)
2014-03-06 15:30 PST, Rebecca Hauck
no flags Details
fixed test case file (added prefixes) (882 bytes, text/html)
2014-03-06 15:41 PST, Rebecca Hauck
no flags Details
Patch (5.19 KB, patch)
2014-04-07 16:02 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rebecca Hauck 2014-03-06 15:29:51 PST
The attached test file tests this:

inset(calc(25%*3 - 10in))

getComputedStyle(div).getPropertyValue('-webkit-shape-outside') returns:

inset( round 0px 0px 0px 0px / 0px 0px 0px 0px)

The inset args completely vanish.

Some additional info:
- The inline style version of this test passes
- If I drop the '- 10in' from the calc() the args don't vanish
Comment 1 Rebecca Hauck 2014-03-06 15:30:25 PST
Created attachment 226049 [details]
Test case for bug
Comment 2 Rebecca Hauck 2014-03-06 15:30:43 PST
Note: This uses testharness.js and the relative path in the test assumes the test is run from LayoutTests/fast/shapes/parsing
Comment 3 Rebecca Hauck 2014-03-06 15:41:13 PST
Created attachment 226052 [details]
fixed test case file (added prefixes)
Comment 4 Zoltan Horvath 2014-04-07 16:02:46 PDT
Created attachment 228766 [details]
Patch
Comment 5 Zoltan Horvath 2014-04-07 16:14:16 PDT
Comment on attachment 228766 [details]
Patch

Note: the simplest serialization for shapes will be implemented in bug #129825.
Comment 6 Bem Jones-Bey 2014-04-07 16:23:41 PDT
Comment on attachment 228766 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2014-04-07 17:02:25 PDT
Comment on attachment 228766 [details]
Patch

Clearing flags on attachment: 228766

Committed r166894: <http://trac.webkit.org/changeset/166894>
Comment 8 WebKit Commit Bot 2014-04-07 17:02:30 PDT
All reviewed patches have been landed.  Closing bug.