Bug 129669

Summary: Move the rest of Source/WebCore/html/ code to std::unique_ptr
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128007    
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Description Zan Dobersek 2014-03-04 01:23:17 PST
Move the rest of Source/WebCore/html/ code to std::unique_ptr
Comment 1 Zan Dobersek 2014-03-04 01:24:02 PST
Created attachment 225753 [details]
Patch
Comment 2 Zan Dobersek 2014-03-25 13:38:47 PDT
Created attachment 227789 [details]
Patch
Comment 3 Anders Carlsson 2014-03-29 09:03:41 PDT
Comment on attachment 227789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227789&action=review

> Source/WebCore/html/FormController.cpp:219
> +    return std::move(savedFormState);

Is move really needed here?

> Source/WebCore/html/FormController.cpp:289
> +    FormKeyGenerator() = default;

Does this constructor even have to be defined?

> Source/WebCore/html/FormController.cpp:399
> +    auto keyGenerator = std::make_unique<FormKeyGenerator>();

Maybe FormKeyGenerator can just be allocated on the stack?

> Source/WebCore/html/FormController.cpp:459
> +        std::unique_ptr<SavedFormState> state = SavedFormState::deserialize(stateVector, i);

auto.
Comment 4 Zan Dobersek 2014-03-31 03:46:53 PDT
Committed r166491: <http://trac.webkit.org/changeset/166491>