Summary: | Move the rest of Source/WebCore/html/ code to std::unique_ptr | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 128007 | ||||||||
Attachments: |
|
Description
Zan Dobersek
2014-03-04 01:23:17 PST
Created attachment 225753 [details]
Patch
Created attachment 227789 [details]
Patch
Comment on attachment 227789 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227789&action=review > Source/WebCore/html/FormController.cpp:219 > + return std::move(savedFormState); Is move really needed here? > Source/WebCore/html/FormController.cpp:289 > + FormKeyGenerator() = default; Does this constructor even have to be defined? > Source/WebCore/html/FormController.cpp:399 > + auto keyGenerator = std::make_unique<FormKeyGenerator>(); Maybe FormKeyGenerator can just be allocated on the stack? > Source/WebCore/html/FormController.cpp:459 > + std::unique_ptr<SavedFormState> state = SavedFormState::deserialize(stateVector, i); auto. Committed r166491: <http://trac.webkit.org/changeset/166491> |