Bug 129217

Summary:

Web Inspector: convert model tests and inspector-test.js to use Test.html

Product:

WebKit

Reporter:

Blaze Burg <bburg>

Component:

Web Inspector

Assignee:

Blaze Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bunhere, cdumez, chrisjshull, commit-queue, graouts, gyuyoung.kim, joepeck, sergio, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

129190, 129642

Bug Blocks:

129744, 130145

Attachments:

Description	Flags
the patch	timothy: review+

Blaze Burg

Reported 2014-02-22 15:21:20 PST

Once https://bugs.webkit.org/show_bug.cgi?id=129190 is fixed, we can remove the special file-loading code from the InspectorTest.js. I would also like to move model/controller tests (those that use a full-blown inspector instead of just listeners for the raw protocol) to LayoutTests/inspector, and use a different inspector-test.js harness there.

Attachments
the patch (107.23 KB, patch) 2014-03-06 14:27 PST, Blaze Burg	timothy: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-02-22 15:21:38 PST

<rdar://problem/16142670>

Blaze Burg

Comment 2 2014-03-03 18:25:35 PST

I am mostly done with this, but it may be blocked by flakiness of inspector/test-harness-trivially-works.html

Blaze Burg

Comment 3 2014-03-06 14:27:01 PST

Created attachment 226039 [details] the patch

Blaze Burg

Comment 4 2014-03-10 11:12:33 PDT

Ready for review

Timothy Hatcher

Comment 5 2014-03-12 12:10:11 PDT

Comment on attachment 226039 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=226039&action=review > Source/WebInspectorUI/UserInterface/Test.html:87 > + <script src="Models/Profile.js"></script> > + <script src="Models/ProfileNode.js"></script> > + <script src="Models/ProfileNodeCall.js"></script> > + <script src="Models/TimelineRecord.js"></script> > + <script src="Models/LayoutTimelineRecord.js"></script> > + <script src="Models/ResourceTimelineRecord.js"></script> > + <script src="Models/ScriptTimelineRecord.js"></script> > + <script src="Models/Timeline.js"></script> > + <script src="Models/NetworkTimeline.js"></script> > + <script src="Models/SourceCodeTimeline.js"></script> > + <script src="Models/TimelineMarker.js"></script> > + <script src="Models/TimelineRecording.js"></script> Should be sorted (and match Main.html).

Blaze Burg

Comment 6 2014-03-12 13:55:39 PDT

Comment on attachment 226039 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=226039&action=review >> Source/WebInspectorUI/UserInterface/Test.html:87 >> + <script src="Models/TimelineRecording.js"></script> > > Should be sorted (and match Main.html). The subclassing tripped me up, will fix.

Blaze Burg

Comment 7 2014-03-12 13:58:16 PDT

I will land this but the inspector directory is marked as skipped until https://webkit.org/b/129642 is fixed, as that assert could be hit on any test converted in this patch.

Blaze Burg

Comment 8 2014-03-12 15:19:50 PDT

Committed <http://trac.webkit.org/changeset/165501>

Note You need to log in before you can comment on or make changes to this bug.