Bug 129159

Summary: Revive SABI (aka shouldAlwaysBeInlined)
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 112840    
Attachments:
Description Flags
the patch mhahnenberg: review+

Filip Pizlo
Reported Friday, February 21, 2014 7:39:09 PM UTC
JSC has some cleverness for rapidly identifying functions that will always be inlined and so do not need to be separately optimized. We broke this when we got rid of the baseline JIT inline caches and replaced them with the DFG ones.
Attachments
the patch (1.57 KB, patch)
2014-02-21 11:40 PST, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 Friday, February 21, 2014 7:40:57 PM UTC
Created attachment 224886 [details] the patch
Mark Hahnenberg
Comment 2 Friday, February 21, 2014 7:42:04 PM UTC
Comment on attachment 224886 [details] the patch r=me
Filip Pizlo
Comment 3 Friday, February 21, 2014 7:43:17 PM UTC
Landed in http://trac.webkit.org/changeset/164490
Note You need to log in before you can comment on or make changes to this bug.