Bug 129078

Summary:

Start to use std::unique_ptr for DragImageLoader

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

New Bugs

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alex.christensen, commit-queue, esprehn+autocc, kangil.han, kling, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

128007

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none

Description Gyuyoung Kim 2014-02-19 18:15:17 PST

As a step to use std::unique_ptr, this patch replace uses of OwnPtr and PassOwnPtr in the DragImageLoader class with std::unique_ptr.

Comment 1 Gyuyoung Kim 2014-02-19 18:16:16 PST

Created attachment 224699 [details]
Patch

Comment 2 Alex Christensen 2014-02-20 16:37:42 PST

looks good to me, but I'm not a reviewer yet :(

Comment 3 Ryosuke Niwa 2014-02-20 16:45:57 PST

Comment on attachment 224699 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224699&action=review

> Source/WebCore/dom/Clipboard.cpp:45
>      WTF_MAKE_FAST_ALLOCATED;

We should probably make this class non-copyable as well...

Comment 4 Gyuyoung Kim 2014-02-20 18:09:52 PST

Created attachment 224816 [details]
Patch for landing

Comment 5 Gyuyoung Kim 2014-02-20 18:12:57 PST

Created attachment 224817 [details]
Patch for landing

Comment 6 Gyuyoung Kim 2014-02-20 19:59:39 PST

Committed r164465: <http://trac.webkit.org/changeset/164465>