Bug 129023

Summary: Correctly install libllvmForJSC.dylib in production builds
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, mmirman, mrowe, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 112840    
Attachments:
Description Flags
the patch
none
the patch
none
the patch
mrowe: review-
the patch mrowe: review+

Description Filip Pizlo 2014-02-18 20:45:21 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2014-02-18 20:46:18 PST
Created attachment 224583 [details]
the patch
Comment 2 Filip Pizlo 2014-02-18 20:51:04 PST
Created attachment 224584 [details]
the patch

Fix install path.
Comment 3 Filip Pizlo 2014-02-18 21:03:40 PST
Created attachment 224585 [details]
the patch
Comment 4 Mark Rowe (bdash) 2014-02-18 21:15:36 PST
Comment on attachment 224585 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224585&action=review

> Source/JavaScriptCore/Configurations/Base.xcconfig:111
> +JAVASCRIPTCORE_LIBRARIES_DIR_macosx = JavaScriptCore.framework/Versions/A/Resources;

This isn't the right path.

I'd suggest pulling out a JAVASCRIPTCORE_CONTENTS_DIR variable that's JavaScriptCore.framework on iOS and JavaScriptCore.framework/Versions/A on OS X, then just defining JAVASCRIPTCORE_RESOURCES_DIR = $(JAVASCRIPTCORE_CONTENTS_DIR)/Resources and JAVASCRIPTCORE_LIBRARIES_DIR = $(JAVASCRIPTCORE_CONTENTS_DIR)/Libraries/. We don't need to repeat the conditionals twice.
Comment 5 Filip Pizlo 2014-02-18 21:29:38 PST
Created attachment 224589 [details]
the patch
Comment 6 Filip Pizlo 2014-02-18 21:41:35 PST
Landed in http://trac.webkit.org/changeset/164354