Summary: | Correctly install libllvmForJSC.dylib in production builds | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | barraclough, ggaren, mark.lam, mhahnenberg, mmirman, mrowe, msaboff, nrotem, oliver, sam | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 112840 | ||||||||||||
Attachments: |
|
Description
Filip Pizlo
2014-02-18 20:45:21 PST
Created attachment 224583 [details]
the patch
Created attachment 224584 [details]
the patch
Fix install path.
Created attachment 224585 [details]
the patch
Comment on attachment 224585 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=224585&action=review > Source/JavaScriptCore/Configurations/Base.xcconfig:111 > +JAVASCRIPTCORE_LIBRARIES_DIR_macosx = JavaScriptCore.framework/Versions/A/Resources; This isn't the right path. I'd suggest pulling out a JAVASCRIPTCORE_CONTENTS_DIR variable that's JavaScriptCore.framework on iOS and JavaScriptCore.framework/Versions/A on OS X, then just defining JAVASCRIPTCORE_RESOURCES_DIR = $(JAVASCRIPTCORE_CONTENTS_DIR)/Resources and JAVASCRIPTCORE_LIBRARIES_DIR = $(JAVASCRIPTCORE_CONTENTS_DIR)/Libraries/. We don't need to repeat the conditionals twice. Created attachment 224589 [details]
the patch
Landed in http://trac.webkit.org/changeset/164354 |