Bug 129018

Summary: The shell scripts in the Xcode build system should tell you when they failed
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, mmirman, mrowe, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 129019, 112840    
Attachments:
Description Flags
the patch
none
the patch mrowe: review+

Filip Pizlo
Reported 2014-02-18 19:40:37 PST
Patch forthcoming.
Attachments
the patch (3.28 KB, patch)
2014-02-18 19:41 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (8.13 KB, patch)
2014-02-18 19:54 PST, Filip Pizlo 		mrowe: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-02-18 19:41:34 PST
Created attachment 224577 [details] the patch
Mark Rowe (bdash)
Comment 2 2014-02-18 19:44:50 PST
Comment on attachment 224577 [details] the patch These could a single invocation as "set -ex", but I'm not sure why you're doing "set -x" in the first place. That's going to make things awfully verbose. It's also not clear why you're only updating these two phases rather than all of the script phases in JavaScriptCore.xcodeproj (and the remainder of WebKit).
Filip Pizlo
Comment 3 2014-02-18 19:54:26 PST
Created attachment 224578 [details] the patch Using set -e only now, and using it in all JSC script phases.
Filip Pizlo
Comment 4 2014-02-18 20:03:51 PST
Landed in http://trac.webkit.org/changeset/164348
Note You need to log in before you can comment on or make changes to this bug.