Bug 128964

Summary:

Move IndexedDB module, LevelDB code to std::unique_ptr

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, commit-queue, jsbell

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

128007

Attachments:

Description	Flags
Patch	kling: review+

Description Zan Dobersek 2014-02-18 02:38:03 PST

Move IndexedDB module, LevelDB code to std::unique_ptr

Comment 1 Zan Dobersek 2014-02-18 02:39:11 PST

Created attachment 224488 [details]
Patch

Comment 2 Andreas Kling 2014-02-18 10:32:34 PST

Comment on attachment 224488 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224488&action=review

r=me

> Source/WebCore/Modules/indexeddb/IDBPendingDeleteCall.h:38
> +    IDBPendingDeleteCall(PassRefPtr<IDBCallbacks> callbacks)

explicit

> Source/WebCore/platform/leveldb/LevelDBDatabase.cpp:266
> +    IteratorImpl(std::unique_ptr<leveldb::Iterator>);

explicit

> Source/WebCore/platform/leveldb/LevelDBTransaction.h:102
> +        TreeIterator(LevelDBTransaction*);

explicit

> Source/WebCore/platform/leveldb/LevelDBTransaction.h:124
> +        TransactionIterator(PassRefPtr<LevelDBTransaction>);

explicit

> Source/WebCore/platform/leveldb/LevelDBTransaction.h:174
> +    LevelDBWriteOnlyTransaction(LevelDBDatabase*);

explicit

Comment 3 Zan Dobersek 2014-02-18 14:03:43 PST

Committed r164314: <http://trac.webkit.org/changeset/164314>