Bug 128796

Summary:

Kill some of the last vestiges of the C++ interpreter's PICs

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, commit-queue, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

128795

Attachments:

Description	Flags
the patch	msaboff: review+
the patch	none

Description Filip Pizlo 2014-02-13 20:31:03 PST

Patch forthcoming.

Comment 1 Filip Pizlo 2014-02-13 20:31:47 PST

Created attachment 224154 [details]
the patch

Comment 2 WebKit Commit Bot 2014-02-13 20:34:04 PST

Attachment 224154 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccessStructureList.h:67:  _stubRoutine is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccessStructureList.h:67:  _base is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccessStructureList.h:67:  _chain is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccessStructureList.h:67:  _isDirect is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccessStructureList.h:67:  _count is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 5 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Filip Pizlo 2014-02-13 20:57:06 PST

Created attachment 224157 [details]
the patch

Still R=michael, trying to fix the build.

Comment 4 WebKit Commit Bot 2014-02-13 20:58:50 PST

Attachment 224157 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccessStructureList.h:67:  _stubRoutine is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccessStructureList.h:67:  _base is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccessStructureList.h:67:  _chain is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccessStructureList.h:67:  _isDirect is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccessStructureList.h:67:  _count is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 5 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Filip Pizlo 2014-02-13 21:35:25 PST

Landed in http://trac.webkit.org/changeset/164092