Bug 128496

Summary:

[GTK] Fix modifiers on EventSenderProxy::keyDown

Product:

WebKit

Reporter:

Carlos Garnacho <carlosg>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch, fixes modifiers on keyDown	cgarcia: review+, cgarcia: commit-queue-
patch, fix indentation issues	none

Description Carlos Garnacho 2014-02-09 02:21:07 PST

On my patch in bug #128171, I went far too eagerly to check direct usages of wkModifiers, failing to realize that keyDown() was already transforming that to a GTK+ modifier mask at the beginning of the function, I'm attaching a patch that fixes it back, sorry about that...

Comment 1 Carlos Garnacho 2014-02-09 02:23:07 PST

Created attachment 223621 [details]
patch, fixes modifiers on keyDown

Comment 2 WebKit Commit Bot 2014-02-09 02:25:25 PST

Attachment 223621 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:3:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Tools/ChangeLog:4:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Carlos Garcia Campos 2014-02-09 02:26:00 PST

Comment on attachment 223621 [details]
patch, fixes modifiers on keyDown

Oops

Comment 4 Carlos Garcia Campos 2014-02-09 02:26:29 PST

Comment on attachment 223621 [details]
patch, fixes modifiers on keyDown

Oh, please fix the changelog.

Comment 5 Carlos Garnacho 2014-02-09 02:36:00 PST

Created attachment 223622 [details]
patch, fix indentation issues

Comment 6 WebKit Commit Bot 2014-02-09 03:34:32 PST

Comment on attachment 223622 [details]
patch, fix indentation issues

Clearing flags on attachment: 223622

Committed r163750: <http://trac.webkit.org/changeset/163750>

Comment 7 WebKit Commit Bot 2014-02-09 03:34:34 PST

All reviewed patches have been landed.  Closing bug.