Bug 128468

Summary: Manage MutationObserverInterestGroup through std::unique_ptr
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kangil.han, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128007    
Attachments:
Description Flags
Patch kling: review+

Description Zan Dobersek 2014-02-08 13:26:30 PST 
Manage MutationObserverInterestGroup through std::unique_ptr
Comment 1 Zan Dobersek 2014-02-08 13:33:33 PST 
Created attachment 223581 [details]
Patch
Comment 2 Andreas Kling 2014-02-08 17:41:49 PST 
Comment on attachment 223581 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223581&action=review

r=me

> Source/WebCore/dom/MutationObserverInterestGroup.h:75
> +    static std::unique_ptr<MutationObserverInterestGroup> createIfNeeded(Node& target, MutationObserver::MutationType, MutationRecordDeliveryOptions oldValueFlag, const QualifiedName* attributeName = 0);

Let's change 0 to nullptr too since we're touching this.
Comment 3 Zan Dobersek 2014-02-09 00:37:46 PST 
Committed r163746: <http://trac.webkit.org/changeset/163746>