Bug 128468 - Manage MutationObserverInterestGroup through std::unique_ptr
Summary: Manage MutationObserverInterestGroup through std::unique_ptr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks: 128007
  Show dependency tree / graph
 
Reported: 2014-02-08 13:26 PST by Zan Dobersek
Modified: 2014-02-09 00:37 PST (History)
8 users (show)

See Also:

Attachments
Patch (9.98 KB, patch)
2014-02-08 13:33 PST, Zan Dobersek 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-02-08 13:26:30 PST 
Manage MutationObserverInterestGroup through std::unique_ptr
Comment 1 Zan Dobersek 2014-02-08 13:33:33 PST 
Created attachment 223581 [details]
Patch
Comment 2 Andreas Kling 2014-02-08 17:41:49 PST 
Comment on attachment 223581 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223581&action=review

r=me

> Source/WebCore/dom/MutationObserverInterestGroup.h:75
> +    static std::unique_ptr<MutationObserverInterestGroup> createIfNeeded(Node& target, MutationObserver::MutationType, MutationRecordDeliveryOptions oldValueFlag, const QualifiedName* attributeName = 0);

Let's change 0 to nullptr too since we're touching this.
Comment 3 Zan Dobersek 2014-02-09 00:37:46 PST 
Committed r163746: <http://trac.webkit.org/changeset/163746>