WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
128468
Manage MutationObserverInterestGroup through std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=128468
Summary
Manage MutationObserverInterestGroup through std::unique_ptr
Zan Dobersek
Reported
2014-02-08 13:26:30 PST
Manage MutationObserverInterestGroup through std::unique_ptr
Attachments
Patch
(9.98 KB, patch)
2014-02-08 13:33 PST
,
Zan Dobersek
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2014-02-08 13:33:33 PST
Created
attachment 223581
[details]
Patch
Andreas Kling
Comment 2
2014-02-08 17:41:49 PST
Comment on
attachment 223581
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=223581&action=review
r=me
> Source/WebCore/dom/MutationObserverInterestGroup.h:75 > + static std::unique_ptr<MutationObserverInterestGroup> createIfNeeded(Node& target, MutationObserver::MutationType, MutationRecordDeliveryOptions oldValueFlag, const QualifiedName* attributeName = 0);
Let's change 0 to nullptr too since we're touching this.
Zan Dobersek
Comment 3
2014-02-09 00:37:46 PST
Committed
r163746
: <
http://trac.webkit.org/changeset/163746
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug