Bug 128436

Summary: Web Inspector: DataGrid header should be position:sticky instead of a separate table
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 128486    
Bug Blocks:    
Attachments:
Description Flags
patch
none
Patch timothy: review+, burg: commit-queue-

Blaze Burg
Reported 2014-02-07 19:39:15 PST
This also means the table need not be fixed-layout. Whether this simplifies widths assignment remains to be seen.
Attachments
patch (21.96 KB, patch)
2014-02-08 21:03 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch (22.13 KB, patch)
2014-07-31 13:19 PDT, Brian Burg 		timothy: review+
burg: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-02-07 19:39:48 PST
<rdar://problem/16018605>
Blaze Burg
Comment 2 2014-02-08 21:03:05 PST
Created attachment 223606 [details] patch
Blaze Burg
Comment 3 2014-02-08 21:06:05 PST
It works, but is an effective style regression due to rendering bugs. Wait before landing.
Timothy Hatcher
Comment 4 2014-02-09 13:14:25 PST
Sweet! What style regressions? I know there are a few other stylesheets that might use "table.data" in the selector — namely TimelineDataGrid.css. Should be easy to grep for.
Blaze Burg
Comment 5 2014-02-10 10:00:08 PST
Regression is being worked on here: https://bugs.webkit.org/show_bug.cgi?id=128486 Looks related to subpixel or position:sticky + tables.
Brian Burg
Comment 6 2014-07-31 13:19:51 PDT
Created attachment 235838 [details] Patch Rebased onto new directory structure. The visual glitches from before seem to be gone.
Timothy Hatcher
Comment 7 2014-07-31 13:30:05 PDT
Comment on attachment 235838 [details] Patch I do have concerns this might break selectors that style DataGrid. Does Timeline look as expected? Any other DataGrids? At least we had API for scrollContainer.
Brian Burg
Comment 8 2014-07-31 17:31:24 PDT
Comment on attachment 235838 [details] Patch I will double-check for style regressions tomorrow when I am physically sitting at the computer where I rebased this. I was mainly checking for the subpixel bug.
Joseph Pecoraro
Comment 9 2019-09-13 11:30:40 PDT
This never landed. Should we close out the bug?
Note You need to log in before you can comment on or make changes to this bug.