| Summary: | Web Inspector: DataGrid header should be position:sticky instead of a separate table | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | NEW --- | ||||||||
| Severity: | Normal | CC: | inspector-bugzilla-changes, joepeck, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | 128486 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
BJ Burg
2014-02-07 19:39:15 PST
Created attachment 223606 [details]
patch
It works, but is an effective style regression due to rendering bugs. Wait before landing. Sweet! What style regressions? I know there are a few other stylesheets that might use "table.data" in the selector — namely TimelineDataGrid.css. Should be easy to grep for. Regression is being worked on here: https://bugs.webkit.org/show_bug.cgi?id=128486 Looks related to subpixel or position:sticky + tables. Created attachment 235838 [details]
Patch
Rebased onto new directory structure. The visual glitches from before seem to be gone.
Comment on attachment 235838 [details]
Patch
I do have concerns this might break selectors that style DataGrid. Does Timeline look as expected? Any other DataGrids? At least we had API for scrollContainer.
Comment on attachment 235838 [details]
Patch
I will double-check for style regressions tomorrow when I am physically sitting at the computer where I rebased this. I was mainly checking for the subpixel bug.
This never landed. Should we close out the bug? |