Bug 12838

Summary:

SVG <use> CSS styles broken

Product:

WebKit

Reporter:

jay <jay>

Component:

SVG

Assignee:

Nikolas Zimmermann <zimmermann>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, zimmermann

Priority:

Keywords:

HasReduction

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

URL:

http://www.peepo.co.uk

Attachments:

Description	Flags
script test case	none
CSS broken for <use>	none
Initial patch	sam: review+

jay

Reported 2007-02-21 02:08:23 PST

mouseover the small circle, a hidden group with three circles should appear. Only one does, the other two are defined by <use> elements

Attachments
script test case (1.25 KB, image/svg+xml) 2007-02-21 02:09 PST, jay	no flags	Details
CSS broken for <use> (3.29 KB, image/svg+xml) 2007-03-13 03:06 PDT, jay	no flags	Details
Initial patch (37.03 KB, patch) 2007-03-17 06:26 PDT, Nikolas Zimmermann	sam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

jay

Comment 1 2007-02-21 02:09:14 PST

Created attachment 13291 [details] script test case

Nikolas Zimmermann

Comment 2 2007-03-01 10:07:33 PST

*** This bug has been marked as a duplicate of 12936 ***

jay

Comment 3 2007-03-13 02:43:34 PDT

remains broken, patch on bug 12936 ineffective.

jay

Comment 4 2007-03-13 03:06:16 PDT

Created attachment 13607 [details] CSS broken for <use>

jay

Comment 5 2007-03-13 03:11:55 PDT

mouse over the two icons in attachment 'CSS broken' in both cases the text appears, however in the <use> case styles don't change. in particular visibility of classes rt and st for #gamesBorder and #sound don't change. this is general to css styles and not particular to visibility. compare with circles whose styles do change. check with mozilla or opera nightly to see appropriate activity.

jay

Comment 6 2007-03-16 14:07:05 PDT

*** Bug 13046 has been marked as a duplicate of this bug. ***

Nikolas Zimmermann

Comment 7 2007-03-17 06:26:56 PDT

Created attachment 13681 [details] Initial patch One-liner fixing all current CSS & <use> problems. Forgot to pass down the StyleChange parameter to the shadow tree root element, when calling recalcStyle. Added new test case based on css-events-webkit.svg. Thanks for the nice testcase!

Sam Weinig

Comment 8 2007-03-17 08:48:28 PDT

Comment on attachment 13681 [details] Initial patch r=me!

Nikolas Zimmermann

Comment 9 2007-03-17 08:53:43 PDT

Fixed - landed in r20262.

jay

Comment 10 2007-03-17 12:35:44 PDT

#7 slightly embarrased, sheepish grin. I like to provide tight test cases and this one isn't that... apologies,

Note You need to log in before you can comment on or make changes to this bug.