Bug 128305

Summary: Verify misspellings after lines merge/split asynchronously
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: HTML EditingAssignee: Grzegorz Czajkowski <g.czajkowski>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 125689    
Attachments:
Description Flags
Patch rniwa: review+

Description Grzegorz Czajkowski 2014-02-06 06:35:30 PST 
Adapt the following spelling tests:
 - editing/spelling/spelling-backspace-between-lines.html
 - editing/spelling/spelling-linebreak.html
to use asynchronous spellchecking.
Comment 1 Grzegorz Czajkowski 2014-02-06 06:38:11 PST 
Created attachment 223330 [details]
Patch
Comment 2 Ryosuke Niwa 2014-02-06 15:24:09 PST 
Comment on attachment 223330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223330&action=review

> LayoutTests/editing/spelling/script-tests/spelling-backspace-between-lines.js:16
> +    div.setAttribute("id", targetName);

Just use .id = ~.

> LayoutTests/editing/spelling/script-tests/spelling-backspace-between-lines.js:17
> +    div.setAttribute("contentEditable", true);

Ditto
Comment 3 Grzegorz Czajkowski 2014-02-07 00:56:13 PST 
(In reply to comment #2)
> (From update of attachment 223330 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=223330&action=review
> 
> > LayoutTests/editing/spelling/script-tests/spelling-backspace-between-lines.js:16
> > +    div.setAttribute("id", targetName);
> 
> Just use .id = ~.
> 
> > LayoutTests/editing/spelling/script-tests/spelling-backspace-between-lines.js:17
> > +    div.setAttribute("contentEditable", true);
> 
> Ditto

Thanks!. I'll apply them before lending.
Comment 4 Grzegorz Czajkowski 2014-02-07 01:15:51 PST 
Committed r163615: <http://trac.webkit.org/changeset/163615>