Bug 128298

Summary: [EFL][WK2] Remove legacy behavior mode in MiniBrowser
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: Tools / TestsAssignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ryuan.choi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jinwoo Song
Reported 2014-02-05 22:28:33 PST
MiniBrowser is crashing when the legacy mode is set in creating webview. As EFL application cannot use this API for creating webview after r146265, it would be better to remove this invalid option.
Attachments
Patch (3.15 KB, patch)
2014-02-05 22:31 PST, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Patch (3.37 KB, patch)
2014-02-05 22:33 PST, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2014-02-05 22:31:39 PST
Created attachment 223310 [details] Patch
Jinwoo Song
Comment 2 2014-02-05 22:33:18 PST
Created attachment 223311 [details] Patch
Gyuyoung Kim
Comment 3 2014-02-05 22:44:41 PST
Comment on attachment 223311 [details] Patch r=me
WebKit Commit Bot
Comment 4 2014-02-05 23:19:37 PST
Comment on attachment 223311 [details] Patch Clearing flags on attachment: 223311 Committed r163518: <http://trac.webkit.org/changeset/163518>
WebKit Commit Bot
Comment 5 2014-02-05 23:19:40 PST
All reviewed patches have been landed. Closing bug.
Ryuan Choi
Comment 6 2014-02-05 23:31:18 PST
(In reply to comment #0) > MiniBrowser is crashing when the legacy mode is set in creating webview. > As EFL application cannot use this API for creating webview after r146265, > it would be better to remove this invalid option. I don't have objection about this because it was not maintained very long time. But, I really hope that we have a way to make applications like almost desktop based browsers using webkit2. Now, MiniBrowser/Efl scaled and fitted contents to webview without any consideration. :(
Jinwoo Song
Comment 7 2014-02-05 23:38:34 PST
(In reply to comment #6) > (In reply to comment #0) > > MiniBrowser is crashing when the legacy mode is set in creating webview. > > As EFL application cannot use this API for creating webview after r146265, > > it would be better to remove this invalid option. > > I don't have objection about this because it was not maintained very long time. > > But, I really hope that we have a way to make applications like almost desktop based browsers using webkit2. > > Now, MiniBrowser/Efl scaled and fitted contents to webview without any consideration. :( I definitely agree to you, so I have a plan to make a API to set fixedLayout and let application to configure it.
Jinwoo Song
Comment 8 2014-02-06 04:32:15 PST
(In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #0) > > > MiniBrowser is crashing when the legacy mode is set in creating webview. > > > As EFL application cannot use this API for creating webview after r146265, > > > it would be better to remove this invalid option. > > > > I don't have objection about this because it was not maintained very long time. > > > > But, I really hope that we have a way to make applications like almost desktop based browsers using webkit2. > > > > Now, MiniBrowser/Efl scaled and fitted contents to webview without any consideration. :( > > I definitely agree to you, so I have a plan to make a API to set fixedLayout and let application to configure it. I filed a bug and upload a patch in bug 128300.
Note You need to log in before you can comment on or make changes to this bug.