Bug 128298

Summary:

[EFL][WK2] Remove legacy behavior mode in MiniBrowser

Product:

WebKit

Reporter:

Jinwoo Song <jinwoo7.song>

Component:

Tools / Tests

Assignee:

Jinwoo Song <jinwoo7.song>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ryuan.choi

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Jinwoo Song 2014-02-05 22:28:33 PST

MiniBrowser is crashing when the legacy mode is set in creating webview.
As EFL application cannot use this API for creating webview after r146265,
it would be better to remove this invalid option.

Comment 1 Jinwoo Song 2014-02-05 22:31:39 PST

Created attachment 223310 [details]
Patch

Comment 2 Jinwoo Song 2014-02-05 22:33:18 PST

Created attachment 223311 [details]
Patch

Comment 3 Gyuyoung Kim 2014-02-05 22:44:41 PST

Comment on attachment 223311 [details]
Patch

r=me

Comment 4 WebKit Commit Bot 2014-02-05 23:19:37 PST

Comment on attachment 223311 [details]
Patch

Clearing flags on attachment: 223311

Committed r163518: <http://trac.webkit.org/changeset/163518>

Comment 5 WebKit Commit Bot 2014-02-05 23:19:40 PST

All reviewed patches have been landed.  Closing bug.

Comment 6 Ryuan Choi 2014-02-05 23:31:18 PST

(In reply to comment #0)
> MiniBrowser is crashing when the legacy mode is set in creating webview.
> As EFL application cannot use this API for creating webview after r146265,
> it would be better to remove this invalid option.

I don't have objection about this because it was not maintained very long time.

But, I really hope that we have a way to make applications like almost desktop based browsers using webkit2.

Now, MiniBrowser/Efl scaled and fitted contents to webview without any consideration. :(

Comment 7 Jinwoo Song 2014-02-05 23:38:34 PST

(In reply to comment #6)
> (In reply to comment #0)
> > MiniBrowser is crashing when the legacy mode is set in creating webview.
> > As EFL application cannot use this API for creating webview after r146265,
> > it would be better to remove this invalid option.
> 
> I don't have objection about this because it was not maintained very long time.
> 
> But, I really hope that we have a way to make applications like almost desktop based browsers using webkit2.
> 
> Now, MiniBrowser/Efl scaled and fitted contents to webview without any consideration. :(

I definitely agree to you, so I have a plan to make a API to set fixedLayout and let application to configure it.

Comment 8 Jinwoo Song 2014-02-06 04:32:15 PST

(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #0)
> > > MiniBrowser is crashing when the legacy mode is set in creating webview.
> > > As EFL application cannot use this API for creating webview after r146265,
> > > it would be better to remove this invalid option.
> > 
> > I don't have objection about this because it was not maintained very long time.
> > 
> > But, I really hope that we have a way to make applications like almost desktop based browsers using webkit2.
> > 
> > Now, MiniBrowser/Efl scaled and fitted contents to webview without any consideration. :(
> 
> I definitely agree to you, so I have a plan to make a API to set fixedLayout and let application to configure it.

I filed a bug and upload a patch in bug 128300.