| Summary: | Manage CalcExpressionNode and derived classes through std::unique_ptr instead of OwnPtr | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 128007 | ||||||
| Attachments: |
|
||||||
|
Description
Zan Dobersek
2014-02-03 12:53:03 PST
Created attachment 223012 [details]
Patch
Comment on attachment 223012 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223012&action=review > Source/WebCore/css/CSSCalculationValue.cpp:401 > + std::unique_ptr<CalcExpressionNode> left(m_leftSide->toCalcValue(style, rootStyle, zoom)); Maybe auto here? > Source/WebCore/css/CSSCalculationValue.cpp:404 > + std::unique_ptr<CalcExpressionNode> right(m_rightSide->toCalcValue(style, rootStyle, zoom)); Maybe auto here? Comment on attachment 223012 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223012&action=review >> Source/WebCore/css/CSSCalculationValue.cpp:401 >> + std::unique_ptr<CalcExpressionNode> left(m_leftSide->toCalcValue(style, rootStyle, zoom)); > > Maybe auto here? I'd rather not -- nothing in 'm_leftSide->toCalcValue(...)' tells me that std::unique_ptr is returned. >> Source/WebCore/css/CSSCalculationValue.cpp:404 >> + std::unique_ptr<CalcExpressionNode> right(m_rightSide->toCalcValue(style, rootStyle, zoom)); > > Maybe auto here? Ditto. Comment on attachment 223012 [details] Patch Clearing flags on attachment: 223012 Committed r163439: <http://trac.webkit.org/changeset/163439> All reviewed patches have been landed. Closing bug. |