Bug 128042 – Use deprecatedCharacters in a few more places (non-Mac-build sites found by EWS)

• Component: Web Template Framework
• Status: RESOLVED FIXED

[Darin Adler]

Use deprecatedCharacters in a few more places (non-Mac-build sites found by EWS)

[Darin Adler]

Created attachment 222882 [details]
Patch

[Geoffrey Garen]

     1>..\platform\win\BString.cpp(84): error C2039: 'deprecatedCharacters' : is not a member of 'WTF::AtomicString'
                 C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\include\private\wtf/text/AtomicString.h(40) : see declaration of 'WTF::AtomicString'

[Geoffrey Garen]

     1>..\platform\graphics\win\FontCacheWin.cpp(450): error C2039: 'deprecatedCharacters' : is not a member of 'WTF::AtomicString'
                 C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\include\private\wtf/text/AtomicString.h(40) : see declaration of 'WTF::AtomicString'
     1>..\platform\graphics\win\FontCacheWin.cpp(450): error C2660: 'memcpy' : function does not take 2 arguments
     1>..\platform\graphics\win\FontCacheWin.cpp(532): error C2039: 'deprecatedCharacters' : is not a member of 'WTF::AtomicString'
                 C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\include\private\wtf/text/AtomicString.h(40) : see declaration of 'WTF::AtomicString'
     1>..\platform\graphics\win\FontCacheWin.cpp(532): error C2660: 'memcpy' : function does not take 2 arguments

[Sam Weinig]

Comment on attachment 222882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222882&action=review

> Source/WebCore/platform/win/BString.cpp:84
> +        m_bstr = SysAllocStringLen(s.deprecatedCharacters(), s.length());

AtomicString does not have a deprecatedCharacters(), so you need to do a s.string().deprecatedCharacters().

[Darin Adler]

Committed r163257: <http://trac.webkit.org/changeset/163257>