Bug 128042

Summary:

Use deprecatedCharacters in a few more places (non-Mac-build sites found by EWS)

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

Web Template Framework

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, commit-queue, ggaren, jsbell

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

126865

Attachments:

Description	Flags
Patch	sam: review+

Description Darin Adler 2014-02-01 08:42:14 PST

Use deprecatedCharacters in a few more places (non-Mac-build sites found by EWS)

Comment 1 Darin Adler 2014-02-01 08:42:44 PST

Created attachment 222882 [details]
Patch

Comment 2 Geoffrey Garen 2014-02-01 10:25:01 PST

     1>..\platform\win\BString.cpp(84): error C2039: 'deprecatedCharacters' : is not a member of 'WTF::AtomicString'
                 C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\include\private\wtf/text/AtomicString.h(40) : see declaration of 'WTF::AtomicString'

Comment 3 Geoffrey Garen 2014-02-01 10:25:30 PST

     1>..\platform\graphics\win\FontCacheWin.cpp(450): error C2039: 'deprecatedCharacters' : is not a member of 'WTF::AtomicString'
                 C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\include\private\wtf/text/AtomicString.h(40) : see declaration of 'WTF::AtomicString'
     1>..\platform\graphics\win\FontCacheWin.cpp(450): error C2660: 'memcpy' : function does not take 2 arguments
     1>..\platform\graphics\win\FontCacheWin.cpp(532): error C2039: 'deprecatedCharacters' : is not a member of 'WTF::AtomicString'
                 C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\include\private\wtf/text/AtomicString.h(40) : see declaration of 'WTF::AtomicString'
     1>..\platform\graphics\win\FontCacheWin.cpp(532): error C2660: 'memcpy' : function does not take 2 arguments

Comment 4 Sam Weinig 2014-02-01 16:05:33 PST

Comment on attachment 222882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222882&action=review

> Source/WebCore/platform/win/BString.cpp:84
> +        m_bstr = SysAllocStringLen(s.deprecatedCharacters(), s.length());

AtomicString does not have a deprecatedCharacters(), so you need to do a s.string().deprecatedCharacters().

Comment 5 Darin Adler 2014-02-01 20:54:50 PST

Committed r163257: <http://trac.webkit.org/changeset/163257>