Summary: | Use deprecatedCharacters in a few more places (non-Mac-build sites found by EWS) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
Component: | Web Template Framework | Assignee: | Darin Adler <darin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | alecflett, commit-queue, ggaren, jsbell | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 126865 | ||||||
Attachments: |
|
Description
Darin Adler
2014-02-01 08:42:14 PST
Created attachment 222882 [details]
Patch
1>..\platform\win\BString.cpp(84): error C2039: 'deprecatedCharacters' : is not a member of 'WTF::AtomicString' C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\include\private\wtf/text/AtomicString.h(40) : see declaration of 'WTF::AtomicString' 1>..\platform\graphics\win\FontCacheWin.cpp(450): error C2039: 'deprecatedCharacters' : is not a member of 'WTF::AtomicString' C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\include\private\wtf/text/AtomicString.h(40) : see declaration of 'WTF::AtomicString' 1>..\platform\graphics\win\FontCacheWin.cpp(450): error C2660: 'memcpy' : function does not take 2 arguments 1>..\platform\graphics\win\FontCacheWin.cpp(532): error C2039: 'deprecatedCharacters' : is not a member of 'WTF::AtomicString' C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\include\private\wtf/text/AtomicString.h(40) : see declaration of 'WTF::AtomicString' 1>..\platform\graphics\win\FontCacheWin.cpp(532): error C2660: 'memcpy' : function does not take 2 arguments Comment on attachment 222882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222882&action=review > Source/WebCore/platform/win/BString.cpp:84 > + m_bstr = SysAllocStringLen(s.deprecatedCharacters(), s.length()); AtomicString does not have a deprecatedCharacters(), so you need to do a s.string().deprecatedCharacters(). Committed r163257: <http://trac.webkit.org/changeset/163257> |