Bug 127904

Summary: Fix compilation on ARM traditional after jsCStack branch merge
Product: WebKit Reporter: Pascal Jacquemart <p.jacquemart>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jbriance, mhahnenberg, msaboff, ossy, rgabor
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645, 127763    
Attachments:
Description Flags
Speculative fix compilation for ARM traditional
none
Add missing pushPair/popPair implementations in macro assembler for traditional ARM. none

Description Pascal Jacquemart 2014-01-30 03:52:18 PST 
Speculative / untested patch to fix compilation for ARM traditional
Comment 1 Pascal Jacquemart 2014-01-30 03:58:09 PST 
Created attachment 222658 [details]
Speculative fix compilation for ARM traditional
Comment 2 Csaba Osztrogonác 2014-01-30 04:34:36 PST 
*** Bug 127856 has been marked as a duplicate of this bug. ***
Comment 3 Pascal Jacquemart 2014-01-31 03:38:30 PST 
I tried to run on board but the build is crashing
In the meantime, it also crashed while disabling JIT at runtime so I might have another issue here ;-(
Comment 4 Julien Brianceau 2014-01-31 06:12:54 PST 
Created attachment 222810 [details]
Add missing pushPair/popPair implementations in macro assembler for traditional ARM.

This one should work better :)
Comment 5 Zoltan Herczeg 2014-01-31 06:30:46 PST 
Comment on attachment 222810 [details]
Add missing pushPair/popPair implementations in macro assembler for traditional ARM.

r=me
Comment 6 WebKit Commit Bot 2014-01-31 07:06:24 PST 
Comment on attachment 222810 [details]
Add missing pushPair/popPair implementations in macro assembler for traditional ARM.

Clearing flags on attachment: 222810

Committed r163169: <http://trac.webkit.org/changeset/163169>
Comment 7 WebKit Commit Bot 2014-01-31 07:06:28 PST 
All reviewed patches have been landed.  Closing bug.