Bug 127834

Summary: EventHandler::handleMouseReleaseEvent shouldn't call updateSelectionCachesIfSelectionIsInsideTextFormControl and selectFrameElementInParentIfFullySelected
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, enrica, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 127831    
Bug Blocks: 127832    
Attachments:
Description Flags
Cleanup ap: review+

Ryosuke Niwa
Reported 2014-01-29 00:30:22 PST
It's bogus to call notifyRendererOfSelectionChange and selectFrameElementInParentIfFullySelected in EventHandler::handleMouseReleaseEvent since setSelection should be calling those functions as needed. We do this because FrameSelection::setNonDirectionalSelectionIfNeeded doesn't call setSelection with EUserTriggered option :(
Attachments
Cleanup (8.10 KB, patch)
2014-01-29 01:54 PST, Ryosuke Niwa 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2014-01-29 01:54:00 PST
Created attachment 222559 [details] Cleanup
Ryosuke Niwa
Comment 2 2014-01-29 17:49:56 PST
Committed r163056: <http://trac.webkit.org/changeset/163056>
Note You need to log in before you can comment on or make changes to this bug.