Bug 127501

Summary: IDB: Implement cross-thread and IPC plumbing for 'get' support
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Severity: Normal CC: alecflett, andersca, ap, bunhere, commit-queue, gyuyoung.kim, jsbell, rakuco, sam, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 124521    
Description Flags
Patch v1 andersca: review+

Description Brady Eidson 2014-01-23 12:07:10 PST
IDB: Implement cross-thread and IPC plumbing for 'get' support
Comment 1 Brady Eidson 2014-01-23 12:08:29 PST
Implementing actual backing store support of fetching the record is tracked in https://bugs.webkit.org/show_bug.cgi?id=127502, as this patch can easily be reviewed/landed separately.
Comment 2 Brady Eidson 2014-01-23 12:12:54 PST
Created attachment 222012 [details]
Patch v1
Comment 3 WebKit Commit Bot 2014-01-23 12:14:35 PST
Attachment 222012 [details] did not pass style-queue:

ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:434:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:80:  The parameter name "keyRange" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 23 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Anders Carlsson 2014-01-23 12:16:50 PST
Comment on attachment 222012 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=222012&action=review

> Source/WebCore/Modules/indexeddb/IDBKeyRangeData.cpp:43
> +    return std::move(result);

No need for move here.
Comment 5 Brady Eidson 2014-01-23 12:21:25 PST