Bug 127333

Summary:

Remove CSS3_TEXT_DECORATION define

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, benjamin, cmarcelo, commit-queue, dbates, dino, d-r, esprehn+autocc, glenn, gyuyoung.kim, jonlee, kondapallykalyan, macpherson, menard, mjs, sam, simon.fraser, syoichi, thorton, webkit-bug-importer, zoltan

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

127193

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	simon.fraser: review+

Myles C. Maxfield

Reported 2014-01-20 20:45:17 PST

Remove CSS3_TEXT_DECORATION define

Attachments
Patch (77.94 KB, patch) 2014-01-20 20:47 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (79.67 KB, patch) 2014-01-21 11:09 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (80.48 KB, patch) 2014-01-21 11:26 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (79.58 KB, patch) 2014-01-21 12:36 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (80.39 KB, patch) 2014-01-21 13:55 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (80.54 KB, patch) 2014-01-21 16:25 PST, Myles C. Maxfield	simon.fraser: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2014-01-20 20:47:42 PST

Created attachment 221717 [details] Patch

Myles C. Maxfield

Comment 2 2014-01-20 20:48:50 PST

<rdar://problem/15345417>

Zoltan Horvath

Comment 3 2014-01-21 09:46:27 PST

The patch looks great. It's good to see that text-decoration is going forward. Are you planning to remove the --[no-]css3-text-decoration option from the build-webkit script in a separate bug?

Myles C. Maxfield

Comment 4 2014-01-21 11:06:23 PST

Whoops! I just forgot it. Adding it in now.

Myles C. Maxfield

Comment 5 2014-01-21 11:09:13 PST

Created attachment 221763 [details] Patch

Myles C. Maxfield

Comment 6 2014-01-21 11:26:59 PST

Created attachment 221767 [details] Patch

Myles C. Maxfield

Comment 7 2014-01-21 12:36:39 PST

Created attachment 221777 [details] Patch