Bug 127333 - Remove CSS3_TEXT_DECORATION define
Summary: Remove CSS3_TEXT_DECORATION define
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 127193
  Show dependency tree / graph
 
Reported: 2014-01-20 20:45 PST by Myles C. Maxfield
Modified: 2014-01-22 18:18 PST (History)
21 users (show)

See Also:

Attachments
Patch (77.94 KB, patch)
2014-01-20 20:47 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (79.67 KB, patch)
2014-01-21 11:09 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (80.48 KB, patch)
2014-01-21 11:26 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (79.58 KB, patch)
2014-01-21 12:36 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (80.39 KB, patch)
2014-01-21 13:55 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (80.54 KB, patch)
2014-01-21 16:25 PST, Myles C. Maxfield 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-01-20 20:45:17 PST 
Remove CSS3_TEXT_DECORATION define
Comment 1 Myles C. Maxfield 2014-01-20 20:47:42 PST 
Created attachment 221717 [details]
Patch
Comment 2 Myles C. Maxfield 2014-01-20 20:48:50 PST 
<rdar://problem/15345417>
Comment 3 Zoltan Horvath 2014-01-21 09:46:27 PST 
The patch looks great. It's good to see that text-decoration is going forward.

Are you planning to remove the --[no-]css3-text-decoration option from the build-webkit script in a separate bug?
Comment 4 Myles C. Maxfield 2014-01-21 11:06:23 PST 
Whoops! I just forgot it. Adding it in now.
Comment 5 Myles C. Maxfield 2014-01-21 11:09:13 PST 
Created attachment 221763 [details]
Patch
Comment 6 Myles C. Maxfield 2014-01-21 11:26:59 PST 
Created attachment 221767 [details]
Patch
Comment 7 Myles C. Maxfield 2014-01-21 12:36:39 PST 
Created attachment 221777 [details]
Patch
Comment 8 Myles C. Maxfield 2014-01-21 13:55:28 PST 
Created attachment 221785 [details]
Patch
Comment 9 Myles C. Maxfield 2014-01-21 16:25:07 PST 
Created attachment 221806 [details]
Patch
Comment 10 Jon Lee 2014-01-22 17:20:20 PST 
The Radar assigned here conflicts with 127193
Comment 11 Radar WebKit Bug Importer 2014-01-22 17:21:56 PST 
<rdar://problem/15887487>
Comment 12 Myles C. Maxfield 2014-01-22 18:18:33 PST 
http://trac.webkit.org/changeset/162579