Bug 127215

Summary:

FTL mishandles (-2147483648 % 0) | 0

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

112840

Attachments:

Description	Flags
the patch	sam: review+

Description Filip Pizlo 2014-01-17 22:14:57 PST

The refactoring that made the ArithDiv and ArithMod share a common path caused this bug.  I think it's generally not a good idea to try to refactor such boilerplate paths into sharing code.  Every time we do it, we get it wrong.

Comment 1 Filip Pizlo 2014-01-17 22:16:12 PST

Created attachment 221536 [details]
the patch

Comment 2 Filip Pizlo 2014-01-17 22:28:14 PST

Landed on branch on http://trac.webkit.org/changeset/162246