Bug 127136

Summary: ArithCos in FTL
Product: WebKit Reporter: Matthew Mirman <mmirman>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
ArithCos patch
sam: review-
ArithCos Patch
none
ArithCos patch without the deleted change log fpizlo: review+

Description Matthew Mirman 2014-01-16 12:51:48 PST 
patch forthcoming
Comment 1 Matthew Mirman 2014-01-16 12:57:38 PST 
Created attachment 221405 [details]
ArithCos patch
Comment 2 Filip Pizlo 2014-01-16 13:35:06 PST 
Comment on attachment 221405 [details]
ArithCos patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221405&action=review

> Source/JavaScriptCore/ChangeLog:37
> +2014-01-16  Matthew Mirman  <mmirman@apple.com>
> +
> +        ArithSin in FTL
> +        https://bugs.webkit.org/show_bug.cgi?id=127129
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * ftl/FTLCapabilities.cpp:
> +        (JSC::FTL::canCompile):
> +        * ftl/FTLIntrinsicRepository.h:
> +        * ftl/FTLLowerDFGToLLVM.cpp:
> +        (JSC::FTL::LowerDFGToLLVM::compileNode):
> +        (JSC::FTL::LowerDFGToLLVM::compileArithSin):
> +        * ftl/FTLOutput.h:
> +        (JSC::FTL::Output::doubleSin):
> +        * tests/stress/ftl-arithsin.js: Added.
> +

You should rebase. ;-)
Comment 3 Sam Weinig 2014-01-16 22:00:51 PST 
Comment on attachment 221405 [details]
ArithCos patch

Looks like you uploaded both cos and sin.
Comment 4 Matthew Mirman 2014-01-20 13:21:12 PST 
Created attachment 221686 [details]
ArithCos Patch
Comment 5 Matthew Mirman 2014-01-20 13:31:26 PST 
Created attachment 221687 [details]
ArithCos patch without the deleted change log
Comment 6 Filip Pizlo 2014-01-20 13:41:09 PST 
Comment on attachment 221687 [details]
ArithCos patch without the deleted change log 

R=me, I will land.
Comment 7 Filip Pizlo 2014-01-20 13:57:24 PST 
Landed in http://trac.webkit.org/changeset/162375