| Summary: | Allow MediaSessionManager to restrict inline <video> playback | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, gyuyoung.kim, jer.noble | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Eric Carlson
2014-01-16 09:08:16 PST
Created attachment 221382 [details]
Proposed patch
Attachment 221382 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/media/video-fullscreeen-only-playback-expected.txt', u'LayoutTests/media/video-fullscreeen-only-playback.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLMediaSession.cpp', u'Source/WebCore/html/HTMLMediaSession.h', u'Source/WebCore/platform/audio/MediaSession.h', u'Source/WebCore/platform/audio/MediaSessionManager.cpp', u'Source/WebCore/platform/audio/MediaSessionManager.h', u'Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm', u'Source/WebCore/testing/Internals.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/html/HTMLMediaSession.cpp:130: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 221387 [details]
Updated patch, now with one less space.
Comment on attachment 221387 [details]
Updated patch, now with one less space.
r=me.
Comment on attachment 221387 [details] Updated patch, now with one less space. Rejecting attachment 221387 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 221387, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: r.h patching file Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm patching file Source/WebCore/testing/Internals.cpp patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/media/video-fullscreeen-only-playback-expected.txt patching file LayoutTests/media/video-fullscreeen-only-playback.html Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Jer Noble']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5912825708937216 Committed r162145: https://trac.webkit.org/r162145 Looks like media/video-controls-visible-audio-only.html has started to fail after this change (it was flaky before, but now it's failing all the time. Eric, Jer, will you be available to look into this? http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fvideo-controls-visible-audio-only.html Filed bug 127147 about that. |