Summary: | [CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mihai Tica <mitica> | ||||||||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | bunhere, cdumez, commit-queue, gyuyoung.kim, krit, rakuco, WebkitBugTracker | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 108546 | ||||||||||||||
Attachments: |
|
Description
Mihai Tica
2014-01-13 06:50:30 PST
Created attachment 221131 [details]
Patch for review
Comment on attachment 221131 [details]
Patch for review
r=me
Comment on attachment 221131 [details] Patch for review Clearing flags on attachment: 221131 Committed r161965: <http://trac.webkit.org/changeset/161965> All reviewed patches have been landed. Closing bug. This test fails with color differences on some bots: <http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK2%20(Tests)/r161973%20(1629)/css3/compositing/background-blend-mode-crossfade-image-diffs.html> Complete history: <http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=css3%2Fcompositing%2Fbackground-blend-mode-crossfade-image.html> Dirk is rolling out in bug 126988. Created attachment 221246 [details]
Includes tests using rectangles instead of circles
Adding a new version of the patch which also tests the hardware path. This version of the tests uses rects instead of circles. Skipping elf for now.
Comment on attachment 221246 [details] Includes tests using rectangles instead of circles View in context: https://bugs.webkit.org/attachment.cgi?id=221246&action=review > LayoutTests/css3/compositing/background-blend-mode-crossfade-image.html:12 > + <svg xmlns="http://www.w3.org/2000/svg" version="1.1" viewBox="0 0 100 100"> \ usually saver to use width="100" height="100" since this does not cause transforms. Also, the version attribute is not necessary. > LayoutTests/css3/compositing/background-blend-mode-crossfade-image.html:17 > + <rect width="100" height="100" fill="#777"/> \ Does the issue occur on 100% opacity as well? Could you use a different color that is more likely to produce a stable color results as you did for bug 118894? Created attachment 221257 [details]
Patch
Test should now show lime (#0f0) rectangles when passing, and red (#f00) when failing.
Created attachment 221258 [details]
Patch
Adding 100% opacity doesn't change the followed code path, adding this value instead.
Created attachment 221361 [details]
Mark test as ImageOnlyFailure for mac
Mark test as ImageOnlyFailure Pass for mac due to the slight differences between blending and the formula result.
Comment on attachment 221361 [details]
Mark test as ImageOnlyFailure for mac
r=me
Comment on attachment 221361 [details] Mark test as ImageOnlyFailure for mac Clearing flags on attachment: 221361 Committed r162348: <http://trac.webkit.org/changeset/162348> All reviewed patches have been landed. Closing bug. |