Summary: | Obey "delete this" comments, including deleting String::characters and friends | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||||||
Component: | WebKit Misc. | Assignee: | Darin Adler <darin> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | benjamin, bfulgham, buildbot, bunhere, cmarcelo, commit-queue, eflews.bot, esprehn+autocc, glenn, gtk-ews, gyuyoung.kim, kondapallykalyan, ltilve+ews, mitz, ossy, peavo, rakuco, rego+ews, rniwa, roger_fong, xan.lopez | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Bug Depends on: | 127624, 128042, 128063 | ||||||||||||||
Bug Blocks: | |||||||||||||||
Attachments: |
|
Description
Darin Adler
2014-01-12 18:34:40 PST
Created attachment 220998 [details]
Patch
Comment on attachment 220998 [details] Patch Attachment 220998 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5184853649653760 Comment on attachment 220998 [details] Patch Attachment 220998 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/6319781309317120 Comment on attachment 220998 [details] Patch Attachment 220998 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4988534721085440 Comment on attachment 220998 [details] Patch Attachment 220998 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/4798223378022400 Comment on attachment 220998 [details] Patch Attachment 220998 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5928938345857024 Comment on attachment 220998 [details] Patch Attachment 220998 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/6291465663676416 Doing this is blocked by redoing the work in bug 126854 or at least renaming the call sites to use deprecatedCharacters. Created attachment 222238 [details]
Patch
Created attachment 222904 [details]
Patch
Created attachment 222928 [details]
Patch
Created attachment 222957 [details]
Patch
Attachment 222957 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/text/WTFString.h:115: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 222957 [details] Patch Clearing flags on attachment: 222957 Committed r163289: <http://trac.webkit.org/changeset/163289> All reviewed patches have been landed. Closing bug. (In reply to comment #14) > (From update of attachment 222957 [details]) > Clearing flags on attachment: 222957 > > Committed r163289: <http://trac.webkit.org/changeset/163289> This broke builds where ENABLE(DATE_AND_TIME_INPUT_TYPES) is true, such as the iOS build, because BaseDateAndTimeInputType.cpp still uses characters(). It broke the WinCairo build too: 1>..\..\win\WebDownloadCurl.cpp(184): error C2039: 'characters' : is not a member of 'WTF::String' C:\Projects\BuildSlave\win-cairo-release\build\WebKitBuild\Release_WinCairo\Include\private\wtf/text/WTFString.h(84) : see declaration of 'WTF::String' 1>..\..\win\WebDownloadCurl.cpp(184): error C2664: 'WebCore::BString::BString(const WebCore::BString &)' : cannot convert argument 1 from 'unsigned int' to 'const wchar_t *' Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast Basically it broke any build without EWS or a buildbot, which is no surprise! |