Bug 126743

Summary: [CSSRegions] Disable accelerated compositing for fixed elements in regions tests
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Mihnea Ovidenie <mihnea>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, krit, ltilve+ews, WebkitBugTracker, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Mihnea Ovidenie
Reported 2014-01-10 02:29:02 PST
Disable accelerated compositing for fixed positioned elements in tests in fast/regions as it is not supported yet. We will add tests with compositing for fixed positioned elements under compositing/regions. This also allows to model the expected files to closer match the behavior in reference files.
Attachments
Patch (4.93 KB, patch)
2014-01-10 03:02 PST, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.35 KB, patch)
2014-01-10 04:09 PST, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mihnea Ovidenie
Comment 1 2014-01-10 03:02:45 PST
Created attachment 220826 [details] Patch
Dirk Schulze
Comment 2 2014-01-10 03:04:45 PST
(In reply to comment #0) > Disable accelerated compositing for fixed positioned elements in tests in fast/regions as it is not supported yet. We will add tests with compositing for fixed positioned elements under compositing/regions. This also allows to model the expected files to closer match the behavior in reference files. Is there a bug for adding the support already? If not, could you create one and add the link to the change log please?
Dirk Schulze
Comment 3 2014-01-10 03:05:26 PST
Comment on attachment 220826 [details] Patch See previous comment.
Mihnea Ovidenie
Comment 4 2014-01-10 03:54:35 PST
(In reply to comment #2) > (In reply to comment #0) > > Disable accelerated compositing for fixed positioned elements in tests in fast/regions as it is not supported yet. We will add tests with compositing for fixed positioned elements under compositing/regions. This also allows to model the expected files to closer match the behavior in reference files. > > Is there a bug for adding the support already? If not, could you create one and add the link to the change log please? Thanks for the review. I will mention https://bugs.webkit.org/show_bug.cgi?id=125144 in the changelog.
Mihnea Ovidenie
Comment 5 2014-01-10 04:09:05 PST
Created attachment 220832 [details] Patch for landing
WebKit Commit Bot
Comment 6 2014-01-10 04:43:28 PST
Comment on attachment 220832 [details] Patch for landing Clearing flags on attachment: 220832 Committed r161631: <http://trac.webkit.org/changeset/161631>
WebKit Commit Bot
Comment 7 2014-01-10 04:43:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.