Bug 126630

Summary: Web Inspector: Remove unused overriding protocols.
Product: WebKit Reporter: Seokju Kwon <seokju>
Component: Web InspectorAssignee: Seokju Kwon <seokju>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, commit-queue, eflews.bot, esprehn+autocc, graouts, gyuyoung.kim, japhet, joepeck, kangil.han, rniwa, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 126236    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Seokju Kwon 2014-01-08 01:45:30 PST
Remove unused overriding protocols.
-Page.setGeolocationOverride
-Page.clearGeolocationOverride
-Page.canOverrideGeolocation
-Page.setDeviceOrientationOverride
-Page.clearDeviceOrientationOverride
-Page.canOverrideGeolocation
-Network.setUserAgentOverride
Comment 1 Radar WebKit Bug Importer 2014-01-08 01:46:13 PST
<rdar://problem/15770823>
Comment 2 Seokju Kwon 2014-01-08 01:50:58 PST
Created attachment 220611 [details]
Patch
Comment 3 Build Bot 2014-01-08 02:16:56 PST
Comment on attachment 220611 [details]
Patch

Attachment 220611 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5122645074903040
Comment 4 Build Bot 2014-01-08 02:39:53 PST
Comment on attachment 220611 [details]
Patch

Attachment 220611 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5909092778377216
Comment 5 EFL EWS Bot 2014-01-08 02:43:54 PST
Comment on attachment 220611 [details]
Patch

Attachment 220611 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/4537931716886528
Comment 6 Joseph Pecoraro 2014-01-08 10:18:24 PST
Comment on attachment 220611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220611&action=review

Other than the build issue this looks good to me.

> Source/WebCore/dom/DeviceOrientationController.cpp:-60
> -    orientation = InspectorInstrumentation::overrideDeviceOrientation(m_page, orientation);

Looks like there is more code that can be removed here, since m_page is no longer used!

(ews-mac build error):
In file included from /Volumes/Data/EWS/WebKit/Source/WebCore/dom/DeviceOrientationController.cpp:28:
/Volumes/Data/EWS/WebKit/Source/WebCore/dom/DeviceOrientationController.h:66:11: error: private field 'm_page' is not used [-Werror,-Wunused-private-field]
    Page* m_page;
          ^
1 error generated.
Comment 7 Seokju Kwon 2014-01-08 17:33:18 PST
Created attachment 220682 [details]
Patch
Comment 8 Seokju Kwon 2014-01-08 17:39:21 PST
Comment on attachment 220682 [details]
Patch

Hum.. Build bots are not working. :(

@Joepeck
I have removed unused private field.
Please take another look at this when build bots are happy.
Comment 9 Build Bot 2014-01-08 18:16:13 PST
Comment on attachment 220682 [details]
Patch

Attachment 220682 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6567514083426304
Comment 10 Build Bot 2014-01-08 18:29:14 PST
Comment on attachment 220682 [details]
Patch

Attachment 220682 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6713594376880128
Comment 11 Seokju Kwon 2014-01-08 19:04:48 PST
Created attachment 220689 [details]
Patch
Comment 12 WebKit Commit Bot 2014-01-09 09:15:35 PST
Comment on attachment 220689 [details]
Patch

Clearing flags on attachment: 220689

Committed r161556: <http://trac.webkit.org/changeset/161556>
Comment 13 WebKit Commit Bot 2014-01-09 09:15:39 PST
All reviewed patches have been landed.  Closing bug.