Bug 126630

Summary: Web Inspector: Remove unused overriding protocols.
Product: WebKit Reporter: Seokju Kwon <seokju>
Component: Web InspectorAssignee: Seokju Kwon <seokju>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, commit-queue, eflews.bot, esprehn+autocc, graouts, gyuyoung.kim, japhet, joepeck, kangil.han, rniwa, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 126236    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Seokju Kwon
Reported 2014-01-08 01:45:30 PST
Remove unused overriding protocols. -Page.setGeolocationOverride -Page.clearGeolocationOverride -Page.canOverrideGeolocation -Page.setDeviceOrientationOverride -Page.clearDeviceOrientationOverride -Page.canOverrideGeolocation -Network.setUserAgentOverride
Attachments
Patch (49.12 KB, patch)
2014-01-08 01:50 PST, Seokju Kwon 		no flags
DetailsFormatted DiffDiff
Patch (51.74 KB, patch)
2014-01-08 17:33 PST, Seokju Kwon 		no flags
DetailsFormatted DiffDiff
Patch (54.24 KB, patch)
2014-01-08 19:04 PST, Seokju Kwon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-01-08 01:46:13 PST
<rdar://problem/15770823>
Seokju Kwon
Comment 2 2014-01-08 01:50:58 PST
Created attachment 220611 [details] Patch
Build Bot
Comment 3 2014-01-08 02:16:56 PST
Comment on attachment 220611 [details] Patch Attachment 220611 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5122645074903040
Build Bot
Comment 4 2014-01-08 02:39:53 PST
Comment on attachment 220611 [details] Patch Attachment 220611 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5909092778377216
EFL EWS Bot
Comment 5 2014-01-08 02:43:54 PST
Comment on attachment 220611 [details] Patch Attachment 220611 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/4537931716886528
Joseph Pecoraro
Comment 6 2014-01-08 10:18:24 PST
Comment on attachment 220611 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220611&action=review Other than the build issue this looks good to me. > Source/WebCore/dom/DeviceOrientationController.cpp:-60 > - orientation = InspectorInstrumentation::overrideDeviceOrientation(m_page, orientation); Looks like there is more code that can be removed here, since m_page is no longer used! (ews-mac build error): In file included from /Volumes/Data/EWS/WebKit/Source/WebCore/dom/DeviceOrientationController.cpp:28: /Volumes/Data/EWS/WebKit/Source/WebCore/dom/DeviceOrientationController.h:66:11: error: private field 'm_page' is not used [-Werror,-Wunused-private-field] Page* m_page; ^ 1 error generated.
Seokju Kwon
Comment 7 2014-01-08 17:33:18 PST
Created attachment 220682 [details] Patch
Seokju Kwon
Comment 8 2014-01-08 17:39:21 PST
Comment on attachment 220682 [details] Patch Hum.. Build bots are not working. :( @Joepeck I have removed unused private field. Please take another look at this when build bots are happy.
Build Bot
Comment 9 2014-01-08 18:16:13 PST
Comment on attachment 220682 [details] Patch Attachment 220682 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6567514083426304
Build Bot
Comment 10 2014-01-08 18:29:14 PST
Comment on attachment 220682 [details] Patch Attachment 220682 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6713594376880128
Seokju Kwon
Comment 11 2014-01-08 19:04:48 PST
Created attachment 220689 [details] Patch
WebKit Commit Bot
Comment 12 2014-01-09 09:15:35 PST
Comment on attachment 220689 [details] Patch Clearing flags on attachment: 220689 Committed r161556: <http://trac.webkit.org/changeset/161556>
WebKit Commit Bot
Comment 13 2014-01-09 09:15:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.