Summary: | Web Inspector: Remove leftover 'device metrics' code | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Seokju Kwon <seokju> | ||||||||
Component: | Web Inspector | Assignee: | Seokju Kwon <seokju> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 126236 | ||||||||||
Attachments: |
|
Description
Seokju Kwon
2014-01-07 17:05:18 PST
Created attachment 220571 [details]
Patch
Comment on attachment 220571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220571&action=review r=me, one nit > Source/WebCore/rendering/TextAutosizer.cpp:119 > if (windowInfo.windowSize.isEmpty()) { > - bool includeScrollbars = !InspectorInstrumentation::shouldApplyScreenWidthOverride(&mainFrame); > - windowInfo.windowSize = mainFrame.view()->unscaledVisibleContentSize(includeScrollbars ? ScrollableArea::IncludeScrollbars : ScrollableArea::ExcludeScrollbars); > + windowInfo.windowSize = mainFrame.view()->unscaledVisibleContentSize(ScrollableArea::IncludeScrollbars); > } Style: Remove the braces for this if now that it is s single statement. (In reply to comment #3) > (From update of attachment 220571 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=220571&action=review > > r=me, one nit > > > Source/WebCore/rendering/TextAutosizer.cpp:119 > > if (windowInfo.windowSize.isEmpty()) { > > - bool includeScrollbars = !InspectorInstrumentation::shouldApplyScreenWidthOverride(&mainFrame); > > - windowInfo.windowSize = mainFrame.view()->unscaledVisibleContentSize(includeScrollbars ? ScrollableArea::IncludeScrollbars : ScrollableArea::ExcludeScrollbars); > > + windowInfo.windowSize = mainFrame.view()->unscaledVisibleContentSize(ScrollableArea::IncludeScrollbars); > > } > > Style: Remove the braces for this if now that it is s single statement. Thanks. I will fix it. Created attachment 220574 [details]
Patch
Created attachment 220576 [details]
Patch
Comment on attachment 220576 [details] Patch Clearing flags on attachment: 220576 Committed r161477: <http://trac.webkit.org/changeset/161477> All reviewed patches have been landed. Closing bug. |