Bug 126554

Summary: style-bot confused about leading spaces
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Gergő Balogh <gbalogh.u-szeged>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ap, gbalogh.u-szeged, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   

Brent Fulgham
Reported 2014-01-06 17:08:19 PST
Style bot seems to believe that code like the following is incorrectly indented: 56: TemporaryOpenGLSetting::~TemporaryOpenGLSetting() 57: { 58: if (m_originalState == m_scopedState) 59: return; 60: 61: if (GL_TRUE == m_originalState) 62: ::glEnable(m_capability); 63: else 64: ::glDisable(m_capability); 65: } ERROR: Source/WebCore/platform/graphics/opengl/TemporaryOpenGLSetting.cpp:56: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/TemporaryOpenGLSetting.cpp:56: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Other code in the same patch is reprimanded with demands that we use two different levels of indentation: 297 ::glStencilMaskSeparate(GL_FRONT, 0xffffffff); 298 clearMask |= GL_STENCIL_BUFFER_BIT; 299 } 300 301 TemporaryOpenGLSetting scopedScissor(GL_SCISSOR_TEST, GL_FALSE); 302 TemporaryOpenGLSetting scopedDither(GL_SCISSOR_TEST, GL_FALSE); 303 304 ::glClear(clearMask); ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:301: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:302: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:301: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:302: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
Attachments
Csaba Osztrogonác
Comment 1 2014-03-03 05:27:46 PST
*** This bug has been marked as a duplicate of bug 127076 ***
Note You need to log in before you can comment on or make changes to this bug.