| Summary: | [CSS Shapes] Simplify FloatRoundedRect, BoxShape construction | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hans Muller <giles_joplin> | ||||||
| Component: | CSS | Assignee: | Hans Muller <giles_joplin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kling, kondapallykalyan | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 219676 [details] Patch. Cleanup of various internal Shape issues: - Removed unnecessary Shape() initialization list entries in Shape subclasses per https://bugs.webkit.org/show_bug.cgi?id=125548#c2. - Used const references instead of pointers for non-deprecated Shape:createShape() logic. - Replaced createShape() overloads for Rasters and Boxes with functions named createRasterShape() and createBoxShape(). - Added a FloatRoundedRect::Radii() constructor to reduce the parameter list length of the FloatRoundedRect constructor in createBoxShape(). There are no new tests, this is just internal refactoring. Comment on attachment 219676 [details]
Patch.
I thought I set r+ on this patch weeks ago :|
Comment on attachment 219676 [details] Patch. Rejecting attachment 219676 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 219676, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5819974354468864 Created attachment 220305 [details]
Patch
Comment on attachment 220305 [details] Patch Clearing flags on attachment: 220305 Committed r161260: <http://trac.webkit.org/changeset/161260> All reviewed patches have been landed. Closing bug. |
Just a small cleanup suggested by Eric Seidel. In Shape.cpp::createShape() (creates a BoxShape), replace this: FloatRoundedRect bounds(rect, roundedRect.radii().topLeft(), roundedRect.radii().topRight(), roundedRect.radii().bottomLeft(), roundedRect.radii().bottomRight()); with this: FloatRoundedRect bounds(rect, roundedRect.radii()); Also: make the change suggested here https://bugs.webkit.org/show_bug.cgi?id=125548#c2.