Bug 125915

Summary:

False webkit-check-style warnings on *

Product:

WebKit

Reporter:

Tamas Gergely <tgergely.u-szeged>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, gbalogh.u-szeged, glenn

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description Tamas Gergely 2013-12-18 02:00:37 PST

The webkit-check-style script reports error on multiplication when it checks the usage * in pointer declarations (e.g. in bug 120284).

Comment 1 Tamas Gergely 2013-12-18 02:03:26 PST

A patch for bug 125846 causes this since r160706.

Comment 2 Gergő Balogh 2013-12-18 07:00:43 PST

Created attachment 219533 [details]
patch

I fix this error.

However keep in mind there is impossible (without a full-parser) to distinguish the following to scenarios.

pointer declaration:
<some type> * <some variable name>;

multiplication:
<some variable name> * <some  (other) variable name>;

Of course the latest one is bad practice. So I only filter the case:
delete <variable name> * <variable name>;
return <variable name> * <variable name>;

Comment 3 WebKit Commit Bot 2013-12-18 10:02:57 PST

Comment on attachment 219533 [details]
patch

Clearing flags on attachment: 219533

Committed r160772: <http://trac.webkit.org/changeset/160772>

Comment 4 WebKit Commit Bot 2013-12-18 10:02:59 PST

All reviewed patches have been landed.  Closing bug.