Bug 125867

Summary: GRAPHICS_SURFACE needed for EGLOffScreenSurface
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, benjamin, cmarcelo, commit-queue, dino, kondapallykalyan, mrobinson, noam, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alex Christensen
Reported 2013-12-17 12:35:31 PST
WebGL doesn't work on Windows with accelerated compositing. GRAPHICS_SURFACE is not necessary except for this compile error, and I'm pretty sure I shouldn't be using it at all. I'm not sure why, and this does not make it draw to the screen, but this fixes a compile error. The notImplemented in createOffScreenSurface is not hit. Also, ENABLE_GLIB_SUPPORT was removed in https://bugs.webkit.org/show_bug.cgi?id=104266 so as long as we're touching WTF, let's clean that up.
Attachments
Patch (2.96 KB, patch)
2013-12-17 12:39 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-12-17 12:39:00 PST
Created attachment 219442 [details] Patch
WebKit Commit Bot
Comment 2 2013-12-17 13:15:22 PST
Comment on attachment 219442 [details] Patch Clearing flags on attachment: 219442 Committed r160725: <http://trac.webkit.org/changeset/160725>
WebKit Commit Bot
Comment 3 2013-12-17 13:15:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.