Bug 125846

Summary:

Fix for C++ should have the & or * beside the type not the variable name check.

Product:

WebKit

Reporter:

Gergő Balogh <gbalogh.u-szeged>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, galpeter, glenn, gyuyoung.kim, ossy, rniwa, tgergely.u-szeged

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Gergő Balogh

Reported 2013-12-17 01:51:28 PST

There is no error message when there is a space between * or & and the variable name. example: const char * currentArgument = argv[++argCounter];

Attachments
patch (2.35 KB, patch) 2013-12-17 02:07 PST, Gergő Balogh	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gergő Balogh

Comment 1 2013-12-17 02:07:58 PST

Created attachment 219404 [details] patch

WebKit Commit Bot

Comment 2 2013-12-17 08:15:09 PST

Comment on attachment 219404 [details] patch Clearing flags on attachment: 219404 Committed r160706: <http://trac.webkit.org/changeset/160706>

WebKit Commit Bot

Comment 3 2013-12-17 08:15:13 PST

All reviewed patches have been landed. Closing bug.

Darin Adler

Comment 4 2013-12-17 09:19:07 PST

This needs to be rolled out. It’s complaining on lines of code that are doing multiplication, such as the ones in bug 120284.

Tamas Gergely

Comment 5 2013-12-18 02:07:04 PST

(In reply to comment #4) > This needs to be rolled out. It’s complaining on lines of code that are doing multiplication, such as the ones in bug 120284. I reported bug 125915 against webkit-check-style for this issue.

Note You need to log in before you can comment on or make changes to this bug.