Bug 125748

Summary: stylebot should warn when FeatureDefines differ
Product: WebKit Reporter: Tim Horton <thorton>
Component: Tools / TestsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, commit-queue, glenn, jianli, mitz, mrowe, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
make stylebot happy :\ none

Tim Horton
Reported 2013-12-14 19:57:01 PST
I have a patch that makes something like this happen: ERROR: Source/WebKit2/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig). [featuredefines/equality] [5] ERROR: Source/WebKit2/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebCore/Configurations/FeatureDefines.xcconfig). [featuredefines/equality] [5] ERROR: Source/WebKit2/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKit/mac/Configurations/FeatureDefines.xcconfig). [featuredefines/equality] [5] ...if you change only one of the FeatureDefines files. Andy recently got us to zero diffs, so we should keep it that way!
Attachments
patch (6.81 KB, patch)
2013-12-14 20:01 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
make stylebot happy :\ (6.78 KB, patch)
2013-12-14 20:09 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-12-14 20:01:00 PST
Created attachment 219267 [details] patch not sure how kosher the file list is (seems a bit unfortunate) but not sure how else to do it.
WebKit Commit Bot
Comment 2 2013-12-14 20:01:50 PST
Attachment 219267 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/style/checker.py', u'Tools/Scripts/webkitpy/style/checkers/featuredefines.py', '--commit-queue']" exit_code: 1 ERROR: Tools/Scripts/webkitpy/style/checkers/featuredefines.py:31: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Tools/Scripts/webkitpy/style/checkers/featuredefines.py:62: no newline at end of file [pep8/W292] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2013-12-14 20:09:05 PST
Created attachment 219268 [details] make stylebot happy :\
WebKit Commit Bot
Comment 4 2013-12-14 20:43:55 PST
Comment on attachment 219268 [details] make stylebot happy :\ Clearing flags on attachment: 219268 Committed r160611: <http://trac.webkit.org/changeset/160611>
WebKit Commit Bot
Comment 5 2013-12-14 20:43:57 PST
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 6 2013-12-16 10:11:26 PST
I wish we could just push all that stuff into a header file.
Csaba Osztrogonác
Comment 7 2014-03-12 03:24:41 PDT
*** Bug 38942 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.