Bug 125616

Summary: check-webkit-style is wrong about style for C++11 lambdas
Product: WebKit Reporter: Brady Eidson <beidson>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: cgarcia, darin, jbedard, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=160910
Attachments:
Description Flags
The fix, without a unit test or a patch to the website to add this exception to the coding style guidelines. none

Brady Eidson
Reported 2013-12-11 22:14:06 PST
check-webkit-style is wrong about style for c++11 lambdas It complains: Place brace on its own line for function definitions. [whitespace/braces] [4] An example patch with the correct style is attached to bug https://bugs.webkit.org/show_bug.cgi?id=125258
Attachments
The fix, without a unit test or a patch to the website to add this exception to the coding style guidelines. (758 bytes, patch)
2013-12-16 14:52 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2013-12-16 14:52:01 PST
Created attachment 219357 [details] The fix, without a unit test or a patch to the website to add this exception to the coding style guidelines. Don't have time to add the exception to the coding style guidelines or write a unit test for this, but this is the fix.
Darin Adler
Comment 2 2016-01-31 20:36:05 PST
*** Bug 137309 has been marked as a duplicate of this bug. ***
Darin Adler
Comment 3 2016-01-31 20:36:32 PST
Bug 153732 shows one of the many, many cases where the style checker gives false positives about this.
Jonathan Bedard
Comment 4 2016-08-26 09:13:03 PDT
*** This bug has been marked as a duplicate of bug 160910 ***
Note You need to log in before you can comment on or make changes to this bug.