Bug 125548

Summary: [CSS Shapes] Simplify the BoxShape implementation
Product: WebKit Reporter: Hans Muller <giles_joplin>
Component: CSSAssignee: Hans Muller <giles_joplin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
kling: review+
Patch none

Hans Muller
Reported 2013-12-10 15:31:04 PST
This change is similar to https://bugs.webkit.org/show_bug.cgi?id=125536. Instead of caching the FloatRoundedRects which represent the BoxShape's shape-padding and shape-margin boundaries, just compute them as needed.
Attachments
Patch (8.79 KB, patch)
2013-12-11 10:20 PST, Hans Muller 		kling: review+
DetailsFormatted DiffDiff
Patch (10.33 KB, patch)
2013-12-18 17:20 PST, Hans Muller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hans Muller
Comment 1 2013-12-11 10:20:11 PST
Created attachment 218974 [details] Patch Reduce BoxShape's footprint by about 2/3rds. Instead of caching the FloatRoundedRects which represent a BoxShape's shape-padding and shape-margin boundaries, compute them as needed. No new tests, this is just an internal refactoring.
Andreas Kling
Comment 2 2013-12-18 10:21:15 PST
Comment on attachment 218974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218974&action=review r=me > Source/WebCore/rendering/shapes/BoxShape.h:41 > + : Shape() This line can be omitted.
Hans Muller
Comment 3 2013-12-18 17:20:00 PST
Created attachment 219592 [details] Patch Resync.
WebKit Commit Bot
Comment 4 2013-12-18 17:52:33 PST
Comment on attachment 219592 [details] Patch Clearing flags on attachment: 219592 Committed r160814: <http://trac.webkit.org/changeset/160814>
WebKit Commit Bot
Comment 5 2013-12-18 17:52:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.