Bug 125443

Summary: check-webkit-style: ternary operator in macro call identified as initialization list
Product: WebKit Reporter: Laszlo Vidacs <lvidacs.u-szeged>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, glenn, lvidacs.u-szeged, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Laszlo Vidacs
Reported 2013-12-09 02:40:08 PST
checkstyle issued error for the following patch: https://bugs.webkit.org/show_bug.cgi?id=125298 /WebKitWebSourceGStreamer.cpp:943: GST_LOG_OBJECT(src, "Have %lld bytes of data", priv->buffer ? static_cast<long long>(gst_buffer_get_size(priv->buffer.get())) : length); ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4]
Attachments
Patch (1.58 KB, patch)
2013-12-09 03:08 PST, Laszlo Vidacs 		no flags
DetailsFormatted DiffDiff
Patch (2.18 KB, patch)
2013-12-09 03:44 PST, Laszlo Vidacs 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Laszlo Vidacs
Comment 1 2013-12-09 03:08:23 PST
Created attachment 218744 [details] Patch
Csaba Osztrogonác
Comment 2 2013-12-09 03:24:44 PST
It would be great if you could add a unit test for this fix.
Laszlo Vidacs
Comment 3 2013-12-09 03:44:45 PST
Created attachment 218747 [details] Patch
WebKit Commit Bot
Comment 4 2013-12-09 10:54:53 PST
Comment on attachment 218747 [details] Patch Clearing flags on attachment: 218747 Committed r160318: <http://trac.webkit.org/changeset/160318>
WebKit Commit Bot
Comment 5 2013-12-09 10:54:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.