Bug 125438

Summary: [EFL][WK2] Move FullScreenManager logic to WebViewEfl
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 125447    
Bug Blocks: 125427    
Attachments:
Description Flags
Patch none

Ryuan Choi
Reported 2013-12-08 22:51:09 PST
Since r160296, there are build break on EFL port.
Attachments
Patch (9.95 KB, patch)
2013-12-08 22:57 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2013-12-08 22:57:39 PST
Created attachment 218727 [details] Patch
Gyuyoung Kim
Comment 2 2013-12-08 23:38:58 PST
Comment on attachment 218727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218727&action=review > Source/WebKit2/UIProcess/efl/WebViewEfl.h:74 > + virtual void closeFullScreenManager() OVERRIDE { } Missing FINAL ?
Ryuan Choi
Comment 3 2013-12-08 23:44:09 PST
Committed r160301: <http://trac.webkit.org/changeset/160301>
Ryuan Choi
Comment 4 2013-12-08 23:45:36 PST
Comment on attachment 218727 [details] Patch cleard flags. I landed patch after adding FINAL keyword.
Gyuyoung Kim
Comment 5 2013-12-09 03:15:48 PST
EFL layout test has broken since this commit. http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/11860
Note You need to log in before you can comment on or make changes to this bug.